Task #54605
closed
Epic #55070: Workpackages
Epic #55065: WP: Overall System Performance (Backend and Frontend)
Epic #55656: Optimize overall Extbase performance
Inject annotations should not be used by core (~5% performance)
Added by Claus Due about 11 years ago.
Updated over 6 years ago.
Description
The case:
Using inject annotations requires the Reflection framework to do expensive runtime analysis of all classes that get loaded (given: only once, if they are Singletons). This extra overhead (I measured it to around 5% in a pretty basic environment with a few extbase plugins) can be very easily avoided by always using injection methods.
I would personally have the core's classes always use injection methods to increase performance of the base system - and warn users in documentation, that inject annotations should be expected to slow down the code by approximately 5% (also affecting cached contexts, especially affecting the backend).
In our quest for better performance we can take this very easy path without any damage.
A revert merge request is coming right up.
- Status changed from New to Under Review
Please check if #52040 should be reverted as well then.
Maybe also search the complete log for such @inject changes.
- Category set to Extbase
- Assignee set to Marc Bastian Heinrichs
- Target version set to next-patchlevel
- Parent task set to #55656
I'm on evaluating this and have a new patchset in the pipeline.
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42270
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42270
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42270
- Status changed from Under Review to Resolved
- Status changed from Resolved to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42277
- Status changed from Under Review to Resolved
- Status changed from Resolved to Closed
Also available in: Atom
PDF