Task #56994: Introduce shadowColumnsForMovePlaceholders property - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (2)

Thorsten Kahler
Timo Webler

Actions

Copy link

Task #56994

closed

Epic #55070: Workpackages

Epic #54851: WP: Workspaces IRRE & MM bugfixes

Story #54853: As a user I want to correctly create, modify, preview and publish IRRE & MM related workspace changes

Task #56376: Invalid relations of IRRE records in workspaces

Introduce shadowColumnsForMovePlaceholders property

Added by Oliver Hader over 10 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Oliver Hader

Category:

Workspaces

Target version:

Start date:

2014-03-17

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

5.3

Tags:

Complexity:

Sprint Focus:

Description

$TCA[<table>]['ctrl']['shadowColumnsForMovePlaceholders'] behaves similar to shadowColumnsForNewPlaceholders but is only used for move placeholders.

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #32967: Backend workspace copy/cut paste column content fails on publish

Closed

2012-01-04

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28473

Actions

Copy link

Updated by Thorsten Kahler over 10 years ago

Status changed from Under Review to Needs Feedback

Why do we need another config option for move placeholders? What's the difference to new placeholders in this context?

Actions

Copy link

Updated by Timo Webler over 10 years ago

Available changes for move placeholder:

#32967
https://review.typo3.org/18107

Actions

Copy link

Updated by Oliver Hader over 10 years ago

Thorsten Kahler wrote:

Why do we need another config option for move placeholders? What's the difference to new placeholders in this context?

The difference is "it is used for move placeholders" only... as written...

The reason for that is the way move-placeholders are overlaid in the frontend.
See https://review.typo3.org/#/c/27774/ and the accordant CSV tests on sorting/moving things...

Actions

Copy link

Updated by Oliver Hader over 10 years ago

Timo Webler wrote:

Available changes for move placeholder:

#32967

https://review.typo3.org/18107

For IRRE that's not enough - the action happens in DataHandlerHook::moveRecord

DataHandler::versionizeRecord (creates version and the new placeholder)
DataHanderHook::moveRecord_wsPlaceholders (creates move placeholder after everything was processed and remapped (remapStack))

I've applied your patch locally and disable the new movePlaceHolder property - the TravisCI test fail

https://travis-ci.org/ohader/TYPO3.CMS/jobs/20950988 (the expected values are not set, thus misusing the newPlaceHolder property is not enough)
https://travis-ci.org/ohader/TYPO3.CMS/jobs/20951081 (disabled the DataSet assertions - thus behaviour in frontend is not as expected)

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Status changed from Needs Feedback to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28473

Actions

Copy link

Updated by Oliver Hader over 10 years ago

Gerrit Code Review wrote:

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28473

This change combines the new property for "move" with the old property for "new" as a fallback...
Thus, one can decide whether to override/disable on demand.

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28473

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28473

Actions

Copy link

#10

Updated by Gerrit Code Review over 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28473

Actions

Copy link

#11