Bug #57706
closed
Install tool marking symlinked directories as errors.
100%
Description
Hi
I am trying a 6.1.7 -> 6.2.0 upgrade and I noticed that the install tool is marking symlinked directories as errors that need to be corrected.
To me this is not an error as symlinks to directories are not errors that need to be corrected. I often symlink entire document roots to quickly switch served content.
I would suggest that if a symlink is detected that the symlink target is followed (using PHP readlink) and then verified. Of course a target can have a different name than it's link, so that would need to be taken in consideration. As long as the link has the correct naming there should be no problems.
Anything can be logically symlinked in a hosting environment for all manner of perfectly valid reasons. They should not be marked as errors unless they are truly broken links. (i.e. the target doesn't exist)
A symlink in itself is not an automatic error without further investigation.
Updated by Mathias Schreiber over 9 years ago
- Target version changed from next-patchlevel to 7.4 (Backend)
Updated by Susanne Moog almost 9 years ago
- Category changed from Install Tool to 1601
Updated by Gerrit Code Review almost 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41383
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41383
Updated by Georg Ringer almost 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset d28bb4270667999d2b82727cbecb8ba7a7fedb8a.
Updated by Gerrit Code Review almost 9 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41404
Updated by Christian Kuhn almost 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset 741c74e4b08ca288b98e2a63e54fc9e7e5e13069.
Updated by Christian Kuhn almost 9 years ago
- Status changed from Resolved to New
Updated by Christian Kuhn almost 9 years ago
The first patches for this issue did not go far enough and had to be reverted:
There are several different scenarios the install tool should cope with. This should be allowed on configuration level:
- example typo3_src: This is usually a link to a directory, but it may be a directory as well.
- example index.php: This is usually a link to a file, but it may also be a file directly, too. The content of the file should have a defined content.
- example fileadmin: This is usually a directory, but it may be a link pointing to a directory as well.
I propose to have a deeper look at the folderStructure DefaultFactory default structure definition and to align on a structural change of the configuration that allows these kind of configuration.
Hint: Since the folder structure can not be extended by extensions, we're relatively free to change this.
Updated by Susanne Moog over 8 years ago
- Target version changed from 7.4 (Backend) to 7.5
Updated by Benni Mack over 8 years ago
- Target version changed from 7.5 to 7 LTS
Updated by Gerrit Code Review almost 8 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48999
Updated by Gerrit Code Review almost 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48999
Updated by Christian Kuhn about 7 years ago
- Status changed from Under Review to Resolved