Task #59112
closedEpic #58282: Workspaces Workpackage #2
Story #58284: Bug fixes & Behaviour
IRRE sorting not reflected
100%
Description
Changing the IRRE element sorting might happen during editing the parent record or directly in the list view.
However, changed sorting is updated in the database but not visualized in the view. Besides that, move-placeholder are not filtered before handing over to the FormEngine.
Files
Updated by Simon Apold about 10 years ago
I can confirm this issue.
To reproduce the problem follow these steps:- clean TYPO3 6.2.4 installation
- install workspace-extension
- create a new workspace
- in the live workspace create a new page with an image content element and add several images to it
- switch to the new created workspace and edit the image content element
- change the order of the images ans save the content element
Neither in the backend nor in the frontend view the changed sorting will take effect. It will show the order of the live workspace.
Updated by Andreas Kießling almost 10 years ago
I also confirm this issue, just tested it with a fresh git checkout.
Reordering inline elements worked in 4.x. Any idea, where to start debugging?
Updated by Andreas Kießling almost 10 years ago
- File 59112.patch 59112.patch added
- File 59112.patch 59112.patch added
I think the problem comes from the change, that the relations now always point to the uid of the live record. I don't think, that the ordering can be determined through SQL, too much overlaying is applied to the records in PHP. The order is properly saved to the DB, but if you save the parent record again, the wrong order gets saved.
The attached patch seems to fix the issue for my 1:n relations and sys_file_references.
But you also need to do the same for all frontend logic! In 4.x, it was enough to determine the right uid to use for fetching the related records, e.g.
uid, _LOCALIZED_UID or _ORIG_uid (if you don't need any l10n overlays) Now you need to do the sorting afterwards
Updated by Andreas Kießling almost 10 years ago
- File 59112_v2.patch 59112_v2.patch added
- File 59112_v2.patch 59112_v2.patch added
Is it safe to rely on $relatedRecords['count']? Sorting should only be done, if there is more then one record, see v2
Updated by Gerrit Code Review about 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39901
Updated by Alexander Opitz about 9 years ago
- Status changed from Under Review to New
- Assignee set to Alexander Opitz
Updated by Alexander Opitz about 9 years ago
- Status changed from New to Under Review
Updated by Alexander Opitz about 9 years ago
- Target version changed from 7.5 to 6.2.14
Updated by Alexander Opitz about 9 years ago
- Target version changed from 6.2.14 to 6.2.15
Updated by Gerrit Code Review about 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39901
Updated by Gerrit Code Review about 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39901
Updated by Gerrit Code Review almost 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39901
Updated by Gerrit Code Review almost 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39901
Updated by Alexander Opitz almost 9 years ago
- Target version changed from 6.2.15 to 6.2.16
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42839
Updated by Gerrit Code Review almost 9 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43421
Updated by Oliver Hader almost 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6873c435dcae6a11e0343f12a403e047ef3cf68f.
Updated by Oliver Hader almost 9 years ago
- Status changed from Resolved to Under Review
Setting to under review again, since only the function tests have been merged
Updated by Oliver Hader almost 9 years ago
- Status changed from Under Review to Resolved
Follow-up in #69967
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from Resolved to Closed
Updated by Christian Kuhn 12 months ago
- Related to Task #69966: Integrate localization and fallback resolving in PlainDataResolver added