Task #59112: IRRE sorting not reflected - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #59112

closed

Epic #58282: Workspaces Workpackage #2

Story #58284: Bug fixes & Behaviour

IRRE sorting not reflected

Added by Oliver Hader almost 10 years ago. Updated 8 months ago.

Status:

Closed

Priority:

Should have

Assignee:

Alexander Opitz

Category:

Workspaces

Target version:

6.2.16

Start date:

2015-09-19

Due date:

% Done:

100%

Estimated time:

(Total: 0.00 h)

TYPO3 Version:

6.2

PHP Version:

5.3

Tags:

Complexity:

hard

Sprint Focus:

Description

Changing the IRRE element sorting might happen during editing the parent record or directly in the list view.
However, changed sorting is updated in the database but not visualized in the view. Besides that, move-placeholder are not filtered before handing over to the FormEngine.

Files

Download all files

Bildschirmfoto_2014-05-26_um_12.53.46.png (30.6 KB) Bildschirmfoto_2014-05-26_um_12.53.46.png		Oliver Hader, 2014-05-26 12:55
59112.patch (759 Bytes) 59112.patch		Andreas Kiessling, 2014-10-16 09:58
59112_v2.patch (768 Bytes) 59112_v2.patch		Andreas Kiessling, 2014-10-16 14:35

Subtasks 1 (0 open — 1 closed)

Related issues 3 (1 open — 2 closed)

Actions

Copy link

Updated by Simon Apold almost 10 years ago

I can confirm this issue.

To reproduce the problem follow these steps:

clean TYPO3 6.2.4 installation
install workspace-extension
create a new workspace
in the live workspace create a new page with an image content element and add several images to it
switch to the new created workspace and edit the image content element
change the order of the images ans save the content element

Neither in the backend nor in the frontend view the changed sorting will take effect. It will show the order of the live workspace.

Actions

Copy link

Updated by Andreas Kiessling over 9 years ago

I also confirm this issue, just tested it with a fresh git checkout.
Reordering inline elements worked in 4.x. Any idea, where to start debugging?

Actions

Copy link

Updated by Andreas Kiessling over 9 years ago

File 59112.patch 59112.patch added
File 59112.patch 59112.patch added

I think the problem comes from the change, that the relations now always point to the uid of the live record. I don't think, that the ordering can be determined through SQL, too much overlaying is applied to the records in PHP. The order is properly saved to the DB, but if you save the parent record again, the wrong order gets saved.

The attached patch seems to fix the issue for my 1:n relations and sys_file_references.

But you also need to do the same for all frontend logic! In 4.x, it was enough to determine the right uid to use for fetching the related records, e.g.
uid, _LOCALIZED_UID or _ORIG_uid (if you don't need any l10n overlays) Now you need to do the sorting afterwards

Actions

Copy link

Updated by Andreas Kiessling over 9 years ago

File 59112_v2.patch 59112_v2.patch added
File 59112_v2.patch 59112_v2.patch added

Is it safe to rely on $relatedRecords['count']? Sorting should only be done, if there is more then one record, see v2

Actions

Copy link

Updated by Mathias Schreiber over 9 years ago

Target version set to 7.5

Actions

Copy link

Updated by Gerrit Code Review almost 9 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39901

Actions

Copy link

Updated by Alexander Opitz almost 9 years ago

Status changed from Under Review to New
Assignee set to Alexander Opitz

Actions

Copy link

Updated by Alexander Opitz almost 9 years ago

Status changed from New to Under Review

Actions

Copy link

Updated by Alexander Opitz almost 9 years ago

Target version changed from 7.5 to 6.2.14

Actions

Copy link

#10

Updated by Alexander Opitz almost 9 years ago

Target version changed from 6.2.14 to 6.2.15

Actions

Copy link

#11

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39901

Actions

Copy link

#12

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39901

Actions

Copy link

#13

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39901

Actions

Copy link

#14

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39901

Actions

Copy link

#15

Updated by Alexander Opitz over 8 years ago

Target version changed from 6.2.15 to 6.2.16

Actions

Copy link

#16

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42839

Actions

Copy link

#17

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43421

Actions

Copy link

#18