Bug #67188
closedEpic #72584: sysext:impexp
Wrong FAL References after Import
100%
Description
Scenario:
Export source systen:
Two sys_file entries were exported with uids 1 and 2. They both have sys_file_reference entries.
Import target system:
There is already one sys_file entry with uid 1.
After Import all sys_file_reference references formerly referenced to sys_file:1 will be referenced to sys_file:3, but they should be refrenced to sys_file:2.
This behavior is caused by TYPO3\CMS\Impexp\ImportExport::fixUidLocalInSysFileReferenceRecords(). During import this function will correctly replace sys_file:1 references with sys_file:2. But when it looks for sys_file:2 to replace, it will not only replace "old" sys_file:2 occurrences, it replaces all sys_file:2 occurrences, which is wrong, because the there are old and new sys_file:2 present in the records array.
Solution:
I fixed this issue with setting a "processed" flag within fixUidLocalInSysFileReferenceRecords() as sibling of the "data" array when replacing the uid_local value of a sys_file_reference entry. Besides checking for file uid equality the if condition checks whether the "processed" flag was set.
There may be a better solution for this problem, i donĀ“t know the impexp extension very well.
Updated by Marc Bastian Heinrichs about 9 years ago
- Status changed from New to Accepted
- Assignee set to Marc Bastian Heinrichs
- Priority changed from Must have to Should have
Updated by Mathias Schreiber almost 9 years ago
- Target version deleted (
next-patchlevel)
Updated by Anja Leichsenring over 8 years ago
- Sprint Focus set to On Location Sprint
Updated by Markus Klein over 8 years ago
- Assignee deleted (
Marc Bastian Heinrichs)
Updated by Nicole Cordes over 8 years ago
- Sprint Focus deleted (
On Location Sprint)
Updated by Christian Kuhn over 6 years ago
- Has duplicate Bug #72207: Files missing in import/export added
Updated by Gerrit Code Review over 6 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55365
Updated by Christian Kuhn over 6 years ago
Confirmed.
This one is nasty. It seems this issue currently also triggers some 'missing / wrong' images if installing ext:introduction distribution.
Special thanks for the explanation and analysis Robert, that helped a lot already.
It took me a while, but I was able to reproduce this locally with your description, then came up with a functional test case to reproduce that in code.
Now lets see if we can fix this issue.
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55365
Updated by Gerrit Code Review over 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55365
Updated by Gerrit Code Review over 6 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55365
Updated by Gerrit Code Review over 6 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55365
Updated by Gerrit Code Review over 6 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55367
Updated by Gerrit Code Review over 6 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55368
Updated by Christian Kuhn over 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset cd7a8572e6be482e8d7adf1bf25209dd1c44e947.
Updated by Marc Bastian Heinrichs over 6 years ago
Kudos Lolli, thx for the hard brain work!
Updated by Markus Klein over 6 years ago
- Related to Bug #84041: Existing file references are modified after export/import added
Updated by Benni Mack almost 6 years ago
- Status changed from Resolved to Closed