Bug #68303

Image width/height are displayed as 0 in backend for default dimensions

Added by filigivuji filigivuji almost 4 years ago. Updated about 2 years ago.

Status:
Accepted
Priority:
Must have
Assignee:
-
Category:
FormEngine aka TCEforms
Start date:
Due date:
% Done:

0%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
hard
Is Regression:
Yes
Sprint Focus:
Remote Sprint

Description

When editing a textpic element in backend, in the tab "Appearance" under "Image Adjustments", width and height are displayed as 0 if no custom size has been chosen. This can be confusing to users, as the images are actually rendered at their full size in the frontend (and are not invisible as the displayed dimensions might suggest).
In TYPO3 versions prior to 6.2.12, the text fields were empty instead, which makes more sense from a user perspective. This change was triggered by 34dd11835be8097c259b4f83e153cddf46dab2b0 in response to #65965.


Related issues

Related to TYPO3 Core - Bug #65965: Wrong $paramsList in FormEngine->getSingleField_typeInput Closed 2015-03-24

History

#1 Updated by Markus Klein almost 4 years ago

  • Status changed from New to Accepted
  • Priority changed from -- undefined -- to Must have
  • Target version set to 7.4 (Backend)
  • Complexity set to medium
  • Sprint Focus set to On Location Sprint

I agree that the situation is not optimal. Unfortunately, FormEngine is not very flexible and the original fix is actually important for many other integer fields, where zero is just a valid number.

We would have to add NULL handling for the width and height fields, which would mean a DB change. That is not feasible for a released version.
Of course we should fix that for CMS 7.

#2 Updated by Helmut Hummel almost 4 years ago

Markus Klein wrote:

I agree that the situation is not optimal. Unfortunately, FormEngine is not very flexible and the original fix is actually important for many other integer fields, where zero is just a valid number.

We would have to add NULL handling for the width and height fields, which would mean a DB change. That is not feasible for a released version.
Of course we should fix that for CMS 7.

Uhm, to me it seems that the original fix must not have gone into 6.2, right?
That is quite a big change in behavior for image size fields.

#3 Updated by Markus Klein almost 4 years ago

The 6.2 fix is ok to my opinion since it improves the situation for many other integer fields. width/height should have a NULL value to indicate "use default".
This can't be changed on 6.2 though.

#4 Updated by Markus Klein almost 4 years ago

  • Priority changed from Must have to Should have
  • Target version changed from 7.4 (Backend) to 6.2.15
  • Complexity changed from medium to hard
  • Sprint Focus changed from On Location Sprint to Stabilization Sprint

#5 Updated by Markus Klein almost 4 years ago

  • Priority changed from Should have to Must have
  • Target version changed from 6.2.15 to 7.5
  • Sprint Focus changed from Stabilization Sprint to Remote Sprint

Christian and me talked about this and took a deeper look into the code. Unfortunately we can't get that right for all cases in 6.2.

We need to fix this on master though.

#6 Updated by Mathias Brodala almost 4 years ago

Still valid with the current 7.5-dev

#7 Updated by Benni Mack over 3 years ago

  • Target version changed from 7.5 to 7 LTS

#8 Updated by Andreas Fernandez over 3 years ago

  • Target version changed from 7 LTS to 8 LTS

After talking with Christian we decided to postpone this ticket to CMS 8.

#9 Updated by Benni Mack about 2 years ago

  • Target version changed from 8 LTS to Candidate for patchlevel

Also available in: Atom PDF