Bug #78002
closed
Require cHash for cached plugin actions in Extbase
100%
Description
As you have seen the discussion with Dmitry Dulepov at twitter reqCHash is only valid for cached plugins: pi_base and also extbase.
Kasper has documented it here:
https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php#L250-L261
In TYPO3 4.5 there was no reqCHash in makeCacheHash. In TYPO3 4.7 it was introduced:
https://review.typo3.org/#/c/4704/
I wonder a bit, because Dmitry wrote "Looks ok to me", so it would be interessting to here why it's not OK today.
Stefan
Updated by Gerrit Code Review over 7 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Dmitry Dulepov over 7 years ago
In TYPO3 4.5 there was no reqCHash in makeCacheHash. In TYPO3 4.7 it was introduced:
It was added because of doParametersRequireCacheHash. This is a new thing, it allows to set some parameters to always require cHash. This is for special applications, not for regular plugins. Do not remove that piece of code or you will break it.
See my comments in the pull request. It needs some changes.
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Dmitry Dulepov over 7 years ago
- Subject changed from Wrong position of reqCHash() to Require cHash for cached plugin actions in Extbase
- Priority changed from Should have to Must have
Updated by Gerrit Code Review over 7 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by
Updated by Gerrit Code Review over 7 years ago
Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Gerrit Code Review over 7 years ago
Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49976
Updated by Anonymous over 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 2769e508741b8561f2236411bc81246a4d4d796d.
Updated by Dmitry Dulepov about 7 years ago
The change will add lots of identical page cache entries for every non-cached action. Very inefficient for the cache and database space in general.
Also I wonder how this works for method="get" and forms. I think it does not.
Anyway, it is already done, so nothing to do now...
Updated by Mathias Brodala almost 7 years ago
- Related to Bug #81297: Extbase record preview leads to 404 due to missing cHash added
Updated by Markus Klein almost 7 years ago
- Related to Bug #81293: cacheHash fails to be generated because of missing id although id is present in request-string added
Updated by Lukas Weiss over 6 years ago
I don't know where to report this, but there's an error in the documentation:
https://docs.typo3.org/typo3cms/extensions/core/8.7/Changelog/8.5/Breaking-78002-EnforceCHashArgumentForExtbaseActions.html
feature.requireCHashArgumentForActionArguments
should be
features.requireCHashArgumentForActionArguments
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed
Updated by Stephan Großberndt over 5 years ago
The documentation error was fixed in https://review.typo3.org/#/c/58002/
Updated by Stephan Großberndt over 5 years ago
- Precedes Task #85942: Fix a typo and add an example for requireCHashArgumentForActionArguments added
Updated by Anonymous over 2 years ago
- Related to Bug #95297: cHash not enforced for Extbase actions anymore added