Bug #79249: TCA fields with eval types "time" or "timesec" are incorrectly stored in the database - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #79249

closed

Epic #77562: Misbehaviors with datetime values and timezones

TCA fields with eval types "time" or "timesec" are incorrectly stored in the database

Added by Dominique Kreemers over 7 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Markus Klein

Category:

DataHandler aka TCEmain

Target version:

next-patchlevel

Start date:

2017-01-10

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.0

Tags:

Complexity:

Is Regression:

Yes

Sprint Focus:

Stabilization Sprint

Description

As mentioned in the title, TCA fields with eval value "time" or "timesec" are stored incorrectly to the database in TYPO3 8.5.1.
In my setup i will get the value "1484084700" in the database if i select 23:45 for the give field.

The documentation suggests that the value will just hold the seconds from 1970-01-01 00:00:00 to the selected time:

https://docs.typo3.org/typo3cms/TCAReference/Reference/Columns/Input/Index.html#eval

The display will be like "23:45" while the database will be "85500".

In TYPO3 8.4.1 this works as expected. It seems like the changes from #77702 have changed this behaviour.

Following code block is responsible for this issue:
(/typo3/sysext/core/Classes/DataHandling/DataHandler.php @Line #2693)

case 'time':
case 'timesec':
case 'date':
case 'datetime':
    // a hyphen as first character indicates a negative timestamp
    if ((strpos($value, '-') === false && strpos($value, ':') === false) || strpos($value, '-') === 0) {
        $value = (int)$value;
    } else {
        // ISO 8601 dates
        $dateTime = new \DateTime($value);
        // The returned timestamp is always UTC
        $value = $dateTime->getTimestamp();
    }
    // $value is a UTC timestamp here.
    // The value will be stored in the server’s local timezone, but treated as UTC, so we brute force
    // subtract the offset here. The offset is subtracted instead of added because the value is stored
    // in the timezone, but interpreted as UTC, so if we switched the server to UTC, the correct
    // value would be returned.
    if ($value !== 0 && !$this->dontProcessTransformations) {
        $value -= date('Z', $value);
    }
    break;

Related issues 6 (1 open — 5 closed)

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

Updated by Dominique Kreemers about 7 years ago

Is Regression changed from No to Yes
Sprint Focus set to Stabilization Sprint

Actions

Copy link

Updated by Gerrit Code Review about 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

Updated by Mona Muzaffar about 7 years ago

Related to Epic #80852: Datetime handling in backend added

Actions

Copy link

Updated by Markus Klein almost 7 years ago

Parent task set to #81489

Actions

Copy link

Updated by Markus Klein almost 7 years ago

Parent task changed from #81489 to #77562

Actions

Copy link

Updated by Markus Klein almost 7 years ago

Has duplicate Bug #79975: TCA -> input -> eval: 'time' not relative timestamp added

Actions

Copy link

Updated by Riccardo De Contardi almost 7 years ago

Related to deleted (Epic #80852: Datetime handling in backend)

Actions

Copy link

#10

Updated by Gerrit Code Review almost 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

#11

Updated by Markus Klein almost 7 years ago

Has duplicate Bug #79957: TCA fields with eval types "time" or "timesec" decrease on every save added

Actions

Copy link

#12

Updated by Markus Klein almost 7 years ago

Has duplicate Bug #80679: Input field eval datetime in FlexForm converts to wrong timestamp added

Actions

Copy link

#13

Updated by Markus Klein almost 7 years ago

Category changed from Backend User Interface to DataHandler aka TCEmain
Assignee set to Markus Klein
Target version set to next-patchlevel

Actions

Copy link

#14

Updated by Markus Klein almost 7 years ago

This can be tested easily with the extension provided in the parent ticket.

Actions

Copy link

#15

Updated by Gerrit Code Review almost 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

#16

Updated by Gerrit Code Review almost 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

#17

Updated by Gerrit Code Review almost 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

#18

Updated by Gerrit Code Review almost 7 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

#19

Updated by Gerrit Code Review almost 7 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53166

Actions

Copy link

#20

Updated by Gerrit Code Review almost 7 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

#21

Updated by Gerrit Code Review almost 7 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

#22

Updated by Gerrit Code Review almost 7 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

#23

Updated by Gerrit Code Review almost 7 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

#24

Updated by Gerrit Code Review almost 7 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

#25

Updated by Gerrit Code Review almost 7 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

#26

Updated by Gerrit Code Review almost 7 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51242

Actions

Copy link

#27

Updated by Gerrit Code Review almost 7 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53166

Actions

Copy link

#28