Actions
Bug #79443
closedTranslation Wizard translates already translated content elements
Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Localization
Target version:
-
Start date:
2017-01-24
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Stabilization Sprint
Description
Problem/Description¶
Scenario¶
- TYPO3 7 LTS (upgraded from former 6.2 LTS > Web was TYPO3 4.5 initally)
- A content page with many content elements where only 2 ce's aren't translated
- default lang is de
- sys_language_uid 1 is en
mod.web_layout.allowInconsistentLanguageHandling = 0
which is the default for TYPO3 7 LTS- the
t3_origuid
andl18n_parent
aren't always exactly the same for each of the translated content elements (they were already present before upgrading TYPO3 - maybe this information helps):
uid sys_language_uid t3_origuid l18n_parent --------------------------------------- 570 1 118 118 571 1 119 119 562 1 408 408 821 1 576 820 1806 1 970 970 977 1 973 973 978 1 974 974 976 1 975 975 1812 1 1808 1808 2286 1 2285 2285 2290 1 976 2289 2294 1 2293 2293 2352 1 2294 2351
Reproduce¶
- Press the "Translate" button
- Preview the record summary: see the bug: already translated CEs are displayed in the record summary
Quickfix / Proposal¶
\TYPO3\CMS\Backend\Domain\Repository\Localization\LocalizationRepository::fetchOriginLanguage:¶
Instead of . ' AND tt_content.t3_origuid = tt_content_orig.uid'
use . ' AND tt_content.l18n_parent = tt_content_orig.uid'
(https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_7-6/typo3/sysext/backend/Classes/Domain/Repository/Localization/LocalizationRepository.php#L40)
At time of issue creation¶
- I didn't tested it in TYPO3 8/8.6.0-dev - the actual implementation in master seems also affected just by reading: https://github.com/TYPO3/TYPO3.CMS/blob/e92276ea39a978d11270e53bc49f97a954094ef7/typo3/sysext/backend/Classes/Domain/Repository/Localization/LocalizationRepository.php#L65
- I don't know if the fix could be a possible solution
Files
Actions