TYPO3 Core

Richard Haeser wrote:

I see the issue with the language menu processor indeed. As far as I can see, you can't add the addQueryString option. But do you have issues with canonical as well? Because that is already adding the current query string.

Have an extension provided with a routeEnhancers, but the Canonical tag on the detail pages does not change and displays the Canonical tag of the page, where the extension is included.

.....
routeEnhancers:
Suffix:
type: PageType
default: ''
map:
sitemap.xml: 1533906435
Location Plugin:
type: Extbase
limitToPages:
- 5
extension: Amlocations
plugin: Locations
routes:
-
routePath: '/ location / {location_title}'
_controller: 'Location :: show'
_arguments:
location_title: location
defaultController: 'Location :: show'
aspects:
location_title:
type: PersistedAliasMapper
tableName: tx_amlocations_domain_model_location
routeFieldName: path_segment

.....

Until this not works and also otherwise, it would be great to provide a hook for the hreflang.

The canonical is only not created correctly when route enhancers are set

I would like to test the patch. Is there already an extension available for 9 LTS that supports route enhancers and has a list and detail view?

To use addQueryString is maybe not a good idea. It would be better to add all params, that are used to generate the cHash. They are stored in the $GLOBALS['TSFE']->cHash_array. Maybe you like to take a look here https://github.com/clickstorm/cs_seo/issues/171

I do not exactly know yet how to properly test the patch, therefore one question:
Does the LanguageMenuProcessor used in the patch check if there is a translation for the record?

Imagine the following:

1. List view:
Default language: www.domain.com/news
Translation: www.domain.de/news
This is easy, since there are no Get-Parameters. It just needs to be checked if the translation for this page exists.

2. List view, page 2
Default language: www.domain.com/news/page/2
It must be checked if this "list view page 2" is available in the translation.
If it is not available, the hreflang for this language needs to be skipped

3. Detail view
Default language: www.domain.com/news/id/25
It must be checked if there is a translation for item 25.
If it is not available, the hreflang for this language needs to be skipped

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58611