Project

General

Profile

Actions

Task #87550

closed

Use controller classes when registering plugins/modules

Added by Alexander Schnitzler almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
Extbase
Start date:
2019-01-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.2
Tags:
Complexity:
Sprint Focus:

Related issues 7 (0 open7 closed)

Related to TYPO3 Core - Bug #88513: Non-FQCN controllers should still be usable in ExtbaseClosed2019-06-06

Actions
Related to TYPO3 Core - Bug #89434: Action argument values will get lost on validation errorClosedAlexander Schnitzler2019-10-16

Actions
Related to TYPO3 Core - Bug #91355: Extension scanner reports correct usages of functionsClosedMarkus Klein2020-05-10

Actions
Related to TYPO3 Core - Bug #91418: UnknownClassException with Fluid autocomplete widgetClosed2020-05-16

Actions
Related to TYPO3 Core - Task #95354: Remove deprecated code from "Use controller classes when registering plugins/modules"Closed2021-09-24

Actions
Related to TYPO3 Core - Task #96298: Remove vendor and non-FQDN handling in extbaseClosed2021-12-08

Actions
Related to TYPO3 Core - Task #96047: Do not register plugins/modules with vendor nameClosedAlexander Schnitzler2021-11-22

Actions
Actions #1

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59566

Actions #2

Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59566

Actions #3

Updated by Gerrit Code Review almost 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59566

Actions #4

Updated by Gerrit Code Review almost 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59566

Actions #5

Updated by Gerrit Code Review almost 6 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59566

Actions #6

Updated by Gerrit Code Review almost 6 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59566

Actions #7

Updated by Anonymous almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions #9

Updated by Oliver Hader over 5 years ago

  • Related to Bug #88513: Non-FQCN controllers should still be usable in Extbase added
Actions #10

Updated by Robert Vock over 5 years ago

Just a small note:
If the configurePlugin call still uses the old controller name without the fully qualified class name and a class with that name exist, the automatic fallback does not work:
ExtensionUtility.php#L76

I don't think there are many instances were this is a problem, but I had a SmartyController and the class Smarty exists, so this code did not work in TYPO3 v10:

\TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
    'VierwdSmarty',
    'smarty_render',
    ['Smarty' => 'render',],
    []
);

I got this exception:

#1476109646 TYPO3\CMS\Extbase\Mvc\Exception\InvalidControllerException
Invalid controller "Smarty". The controller must implement the TYPO3\CMS\Extbase\Mvc\Controller\ControllerInterface.

As I said: I do not think there are many (or even any ;-)) extensions, were this is a problem. I just wanted to leave this note, if someone else has this problem.

Actions #11

Updated by Oliver Hader almost 5 years ago

  • Related to Bug #89434: Action argument values will get lost on validation error added
Actions #12

Updated by Markus Klein over 4 years ago

  • Related to Bug #91355: Extension scanner reports correct usages of functions added
Actions #13

Updated by Oliver Hader over 4 years ago

  • Related to Bug #91418: UnknownClassException with Fluid autocomplete widget added
Actions #14

Updated by Simon Schaufelberger about 3 years ago

  • Related to Task #95354: Remove deprecated code from "Use controller classes when registering plugins/modules" added
Actions #15

Updated by Christian Kuhn almost 3 years ago

  • Related to Task #96298: Remove vendor and non-FQDN handling in extbase added
Actions #16

Updated by Christian Kuhn almost 3 years ago

  • Related to Task #96047: Do not register plugins/modules with vendor name added
Actions

Also available in: Atom PDF