Bug #89558
closedBitmap icons for modules are not rendered anymore
100%
Description
This is the updated module registration for EXT:ig_ldap_sso_auth in TYPO3 v10:
\TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule( $_EXTKEY, 'system', 'txigldapssoauthM1', 'top', [ \Causal\IgLdapSsoAuth\Controller\ModuleController::class => implode(',', [ 'index', 'status', 'search', 'importFrontendUsers', 'importBackendUsers', 'importFrontendUserGroups', 'importBackendUserGroups', ]), ], [ 'access' => 'admin', 'icon' => 'EXT:' . $_EXTKEY . '/Resources/Public/Icons/module-ldap.png', 'labels' => 'LLL:EXT:' . $_EXTKEY . '/Resources/Private/Language/locallang.xlf' ] );
Prior to commit d750a7a2eae (#89206), or in TYPO3 v8/v9, the module was rendered like that:
In TYPO3 v10, this is what happens:
Reason is that this changed:
--- a/typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php +++ b/typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php @@ -348,7 +348,7 @@ class BackendModuleRepository implements \TYPO3\CMS\Core\SingletonInterface $iconRegistry = GeneralUtility::makeInstance(IconRegistry::class); if ($iconRegistry->isRegistered($iconIdentifier)) { $iconFactory = GeneralUtility::makeInstance(IconFactory::class); - return $iconFactory->getIcon($iconIdentifier)->render(); + return $iconFactory->getIcon($iconIdentifier)->render('inline'); } return ''; }
which renders the Bitmap icon as:
<image width="32" height="32" xlink:href="/typo3conf/ext/ig_ldap_sso_auth/Resources/Public/Icons/module-ldap.png"/>
which in turns get interpreted like that by the browser:
<img width="32" height="32" xlink:href="/typo3conf/ext/ig_ldap_sso_auth/Resources/Public/Icons/module-ldap.png"/>
The tag lacks the src
attribute and this originates from asking 'inline' alternative.
Files
Updated by Xavier Perseguers about 5 years ago
- Due date set to 2019-09-20
- Start date changed from 2019-10-31 to 2019-09-20
- Follows Task #89206: Update @typo3/icons to 1.10.0 added
Updated by Gerrit Code Review about 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62168
Updated by Xavier Perseguers over 4 years ago
@Riccardo De Contardi this is not only related, this is a duplicate of this one.
Updated by Susanne Moog over 4 years ago
- Related to Bug #90633: png Icons for BackendModules added
Updated by Benni Mack over 4 years ago
- Target version changed from next-patchlevel to Candidate for patchlevel
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62168
Updated by Gerrit Code Review over 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62168
Updated by Gerrit Code Review over 4 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62168
Updated by Gerrit Code Review over 4 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62168
Updated by Gerrit Code Review over 4 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62168
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64325
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64325
Updated by Gerrit Code Review over 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64325
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64290
Updated by Benjamin Franzke over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 62650559900d7b62b9e15931b54a1b27158627e2.