Bug #91208

Performance issue in PageRepository for Mega Menus

Added by Stefan Froemken 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Should have
Category:
Performance
Target version:
Start date:
2020-04-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hello Core-Team,

one of our customer has over 200 Pages in a Mega Menu. Loading this menu costs 16 seconds.

I have installed Blackfire to find the problem. Generating the where clauses for PageRepository costs 9 seconds in total, because of calling QuoteIdentifier 201.000 times.
I will create a patch, which will reduce this amount of calls below 30.000.

Stefan


Files

WithPatch.png (49.6 KB) WithPatch.png Stefan Froemken, 2020-04-27 19:30
WithoutPatch.png (63.7 KB) WithoutPatch.png Stefan Froemken, 2020-04-27 19:30

Related issues

Related to TYPO3 Core - Bug #57953: Rendering time of HMENU is really bad, maybe bug?Needs Feedback2014-04-15

Actions
Related to TYPO3 Core - Bug #91413: InvalidArgumentException in PageRepository having too many user group idsClosed2020-05-15

Actions
Related to TYPO3 Core - Bug #91428: hidDelWhere cache is not written in v9Closed2020-05-18

Actions
Related to TYPO3 Core - Bug #91429: Initlialisation of $this->where_groupAccess missing in init method of TYPO3\CMS\Frontend\Page\PageRepositoryClosed2020-05-18

Actions
Related to TYPO3 Core - Bug #91432: PageRepository PageRepository_hidDelWhere cache should consider more attributesRejected2020-05-18

Actions
#1

Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321

#2

Updated by Riccardo De Contardi 9 months ago

Can this be considered related? #57953

#3

Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321

#4

Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321

#5

Updated by Stefan Froemken 9 months ago

  • Related to Bug #57953: Rendering time of HMENU is really bad, maybe bug? added
#6

Updated by Gerrit Code Review 9 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321

#7

Updated by Gerrit Code Review 9 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321

#8

Updated by Gerrit Code Review 9 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321

#9

Updated by Stefan Froemken 9 months ago

I have attached 2 images with times from Blackfire IO.

#10

Updated by Gerrit Code Review 9 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321

#11

Updated by Gerrit Code Review 9 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321

#12

Updated by Gerrit Code Review 9 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321

#13

Updated by Gerrit Code Review 9 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321

#14

Updated by Gerrit Code Review 9 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321

#15

Updated by Gerrit Code Review 9 months ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321

#16

Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64355

#17

Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64355

#18

Updated by Stefan Froemken 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#19

Updated by Benni Mack 9 months ago

  • Status changed from Resolved to Closed
#20

Updated by Oliver Hader 9 months ago

  • Related to Bug #91413: InvalidArgumentException in PageRepository having too many user group ids added
#21

Updated by Andreas Fernandez 8 months ago

  • Related to Bug #91428: hidDelWhere cache is not written in v9 added
#22

Updated by Oliver Hader 8 months ago

  • Related to Bug #91429: Initlialisation of $this->where_groupAccess missing in init method of TYPO3\CMS\Frontend\Page\PageRepository added
#23

Updated by Oliver Hader 8 months ago

  • Related to Bug #91432: PageRepository PageRepository_hidDelWhere cache should consider more attributes added

Also available in: Atom PDF