Bug #91208
closed
Performance issue in PageRepository for Mega Menus
Added by Stefan Froemken over 4 years ago. Updated over 4 years ago.
100%
Description
Hello Core-Team,
one of our customer has over 200 Pages in a Mega Menu. Loading this menu costs 16 seconds.
I have installed Blackfire to find the problem. Generating the where clauses for PageRepository costs 9 seconds in total, because of calling QuoteIdentifier 201.000 times.
I will create a patch, which will reduce this amount of calls below 30.000.
Stefan
Files
| WithPatch.png (49.6 KB) WithPatch.png | Stefan Froemken, 2020-04-27 19:30 | ||
| WithoutPatch.png (63.7 KB) WithoutPatch.png | Stefan Froemken, 2020-04-27 19:30 |
Updated by Gerrit Code Review over 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321
Updated by Riccardo De Contardi over 4 years ago
Can this be considered related? #57953
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321
Updated by Gerrit Code Review over 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321
Updated by Stefan Froemken over 4 years ago
- Related to Bug #57953: Rendering time of HMENU is really bad, maybe bug? added
Updated by Gerrit Code Review over 4 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321
Updated by Gerrit Code Review over 4 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321
Updated by Gerrit Code Review over 4 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321
Updated by Stefan Froemken over 4 years ago
- File WithPatch.png WithPatch.png added
- File WithoutPatch.png WithoutPatch.png added
I have attached 2 images with times from Blackfire IO.
Updated by Gerrit Code Review over 4 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321
Updated by Gerrit Code Review over 4 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321
Updated by Gerrit Code Review over 4 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321
Updated by Gerrit Code Review over 4 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321
Updated by Gerrit Code Review over 4 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321
Updated by Gerrit Code Review over 4 years ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64355
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64355
Updated by Stefan Froemken over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset aebc8b87f7247375cf682543528434a3cdb33f9f.
Updated by Oliver Hader over 4 years ago
- Related to Bug #91413: InvalidArgumentException in PageRepository having too many user group ids added
Updated by Andreas Kienast over 4 years ago
- Related to Bug #91428: hidDelWhere cache is not written in v9 added
Updated by Oliver Hader over 4 years ago
- Related to Bug #91429: Initlialisation of $this->where_groupAccess missing in init method of TYPO3\CMS\Frontend\Page\PageRepository added
Updated by Oliver Hader over 4 years ago
- Related to Bug #91432: PageRepository PageRepository_hidDelWhere cache should consider more attributes added
Updated by Benni Mack about 2 years ago
- Related to Bug #98964: Menu object caching creates too many records resulting in huge cache_hash table added