TYPO3 Core

The issue I can see is that the finisher options are not merged. Instead the finisher variant is added as new finisher and thus obviously misses everything from the base finisher.

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70586

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70586

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70586

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70586

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70586

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70586

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70586

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70586

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70586

Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70586

Still present with TYPO3 11.5.12, I think.
Will this be fixed?

I can confirm this issue. Overwriting specific finisher options will delete all previously configured options instead of merging them. Here is my example

finishers:
  1:
    identifier: SaveToDatabase
    options:
      1:
        table: tx_events2_domain_model_time
        mode: insert
        elements:
          time-begin:
            mapOnDatabaseColumn: time_begin
        databaseColumnMappings:
          pid:
            value: 8
          crdate:
            value: '{__currentTimestamp}'
          tstamp:
            value: '{__currentTimestamp}'
      2:
        table: tx_events2_domain_model_event
        mode: insert
        elements:
          choose-event-type:
            mapOnDatabaseColumn: event_type
          title:
            mapOnDatabaseColumn: title
          event-begin:
            mapOnDatabaseColumn: event_begin
            dateFormat: U
          event-end:
            mapOnDatabaseColumn: event_end
            dateFormat: U
          recurring-end:
            mapOnDatabaseColumn: recurring_end
            dateFormat: U
          image-1:
            mapOnDatabaseColumn: images
          image-2:
            mapOnDatabaseColumn: images
        databaseColumnMappings:
          pid:
            value: 8
          crdate:
            value: '{__currentTimestamp}'
          tstamp:
            value: '{__currentTimestamp}'
          hidden:
            value: 1
          event_time:
            value: '{SaveToDatabase.insertedUids.1}'
variants:
-
  identifier: prevent-storing-empty-event-time
  condition: 'formValues["time-begin"] == ""'
  finishers:
    1:
      identifier: SaveToDatabase
      options:
        # Do not create new record for tx_events2_domain_model_time
        1: __UNSET
        2:
          databaseColumnMappings:
            # Remove column mapping for tx_events2_domain_model_time
            event_time: __UNSET

The current patch works perfectly. +1 from my side

Stefan

I not only can confirm this issue (TYPO3 v10.4.32) but have (an) additional problem(s) to solve:
If more than one finisher (e.g. EmailToReceiver and Redirect) is defined, you must add them all to the variant - even if you only want to override a single option from one of them. I guess this would be solved by this patch. But at least until this is merged (hopefully not only for v12) I have the issue that I can't let an editor override the redirect page if the variant condition is valid. I even tried to merge the finishers options within YAML.

Still present in TYPO3 12.4.11