Task #17626: JS-function checkSubmit should not use eval - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (1)

Oliver Hader

Actions

Copy link

Task #17626

closed

JS-function checkSubmit should not use eval

Added by Mads Brunn about 17 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Frank Nägler

Category:

FormEngine aka TCEforms

Target version:

7 LTS

Start date:

2007-09-24

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

The checkSubmit function in typo3/jsfunc.tbe_editor.js (used in backend forms) is in IMHO not correctly implemented.

The lines 260-264 checks if any user-defined javascript (registered with t3lib_tceforms->additionalJS_submit) should be evaluated before the form is submitted.

But it uses the eval-function to execute the javascript and this means that you cannot abort the submit in your own javascript-code (using "return false;") .

(issue imported from #M6392)

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Task #63712: Avoid use of eval() and replace it

Closed

2015-09-30

Actions

Related to TYPO3 Core - Bug #61996: unsafe-eval

Closed

2014-10-01

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Oliver Hader about 17 years ago

Hi,
what do you mean with "abort the submit in your own javascript-code"? Could you please give an example?
We cound integrate another check before line 266, e.g.

if (STOP) {
  return false;
}

So, you can add e.g. the following to t3lib_TCEforms->additionalJS_submit:

if (!MyValidatorObject.someFunction()) {
  STOP = true;
}

Actions

Copy link

Updated by Mads Brunn about 17 years ago

Hi,

Yes, that's exactly what I had in mind.

I want e.g. to do a check on a specific field and if it doesn't have a specific value the submit should be aborted.

Btw. I think this used to work in version 4.0 but back then the code in t3lib_TCEforms->additionalJS_submit was simply injected directly in the onsubmit function.

Actions

Copy link

Updated by Andreas Wolf about 13 years ago

Tracker changed from Bug to Feature
Subject changed from JS-function checkSubmit not correctly implemented to JS-function checkSubmit should not use eval
Category set to FormEngine aka TCEforms
Status changed from New to Accepted
Assignee set to Andreas Wolf
Target version deleted (0)

I guess this is more a feature than a bug... But we should definitely have it.

Actions

Copy link

Updated by Mathias Schreiber almost 10 years ago

Assignee changed from Andreas Wolf to Frank Nägler

Could you check during your FormEngine crusade, please?

Actions

Copy link

Updated by Frank Nägler over 9 years ago

Target version set to 7.4 (Backend)
PHP Version deleted (~~4.3~~)

Actions

Copy link

Updated by Susanne Moog over 9 years ago

Target version changed from 7.4 (Backend) to 7.5

Actions

Copy link

Updated by Benni Mack about 9 years ago

Target version changed from 7.5 to 7 LTS

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43743

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43743

Actions

Copy link

#10

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43743

Actions

Copy link

#11

Updated by Benni Mack about 9 years ago

Tracker changed from Feature to Task

Actions

Copy link

#12

Updated by Gerrit Code Review about 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43743

Actions

Copy link

#13