Project

General

Profile

Actions

Task #17626

closed

JS-function checkSubmit should not use eval

Added by Mads Brunn over 16 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
FormEngine aka TCEforms
Target version:
Start date:
2007-09-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The checkSubmit function in typo3/jsfunc.tbe_editor.js (used in backend forms) is in IMHO not correctly implemented.

The lines 260-264 checks if any user-defined javascript (registered with t3lib_tceforms->additionalJS_submit) should be evaluated before the form is submitted.

But it uses the eval-function to execute the javascript and this means that you cannot abort the submit in your own javascript-code (using "return false;") .

(issue imported from #M6392)


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #63712: Avoid use of eval() and replace itClosed2015-09-30

Actions
Related to TYPO3 Core - Bug #61996: unsafe-evalClosed2014-10-01

Actions
Actions

Also available in: Atom PDF