Feature #19809
closed
make pi_wrapInBaseClass wraps configurable
Added by Steffen Müller almost 16 years ago.
Updated over 11 years ago.
Description
Background:
Plugins often use pi_wrapInBaseClass function in tslib_pibase to wrap the content with a base class. The outcome HTML looks like:
<div class="tx-extensionname-pi1">
... content ...
</div>
This is widespread, because kickstarter ships this function as default.
Problem:
The wraps can be annoying if content is empty or in cases where plugin content is used for AJAX. Unfortunately the wraps are generally not configurable.
Solution:
The appended patch adds some conditions to tslib_pibase::wrapInBaseClass to give user some control (with the precedence that general configuration is overruled by special configuration) :
- no baseWrap container for any plugin if content is empty or new TS option config.disableBaseWrap is set
- custom baseWrap container if configured in TS setup of a certain extension (using stdWrap): plugin.tx_extensionname_pi1.baseWrap
(issue imported from #M10118)
Files
Documentation update:
TSref [tsref:config/->CONFIG]
Property: disableBaseWrap
Data type: boolean
Description: If set, the wrapping <div> container will be disabled in plugins which use $this->wrapInBaseClass()
send as RFC to core list...
but i really like this solution, because we have than stdWrap on plugins which uses pi_wrapInBaseClass = great enhancement:)
This bug is resolved ?
Thanks
No.
It's pending in the core list. No decision yet.
What's the decission?
In which version this option appears on ?
I added another patch according to discussion on the core list.
And version six pending in core list...
- Assignee set to Jigal van Hemert
- Target version changed from 0 to 4.7.0
- % Done changed from 0 to 70
- Complexity set to medium
- Tracker changed from Bug to Feature
- Status changed from New to Under Review
Just created a new review request with the latest patch in the name of Steffen Müller. Is that ok Jigal?
- Target version deleted (
4.7.0)
Nobody wants to care about this feature? If so I will abandon the Gerrit review request soon. If someone wants to continue on this feature, he should look into the comments in Gerrit.
- Status changed from Under Review to New
- Assignee deleted (
Jigal van Hemert)
Like promised I abandoned the request.
- Status changed from New to Rejected
won't be fixed. extbase and fluid is in favor
Wouldn't it then be consequent to remove the whole piBase stuff from core? Rejecting enhancements for piBase means it's dead anyway. sigh
@Steffen: Full ACK. There are still tons of piBase extensions which will stay for years. Therefore we still need this feature.
Also available in: Atom
PDF