TYPO3 Core

Redirection doesn't work for me properly. I'm using TYPO3 4.5.2 and felogin 1.3.1.
To reproduce this issue. Install the current TYPO3 package and set up a redirection in the Login module.

But I have a fix for this.
Simply switch the code segment starting on line 117

    // What to display
  $content='';
  if ($this->piVars['forgot']) {
    $content .= $this->showForgot();
  } elseif ($this->piVars['forgothash']) {
    $content .= $this->changePassword();
  } else {
    if($this->userIsLoggedIn && !$this->logintype) {
      $content .= $this->showLogout();
    } else {
      $content .= $this->showLogin();
    }
  }

with the code segment starting on line 131

  // Process the redirect
if (($this->logintype === 'login' || $this->logintype === 'logout') && $this->redirectUrl && !$this->noRedirect) {
  if (!$GLOBALS['TSFE']->fe_user->cookieId) {
    $content .= $this->cObj->stdWrap($this->pi_getLL('cookie_warning', '', 1), $this->conf['cookieWarning_stdWrap.']);
  } else {
    t3lib_utility_Http::redirect($this->redirectUrl);
  }
}

Under some circumstamces $this->redirectUrl gets assigned an empty string, so that the redirect can't be processed.

Redirection is a must have :)

<b>edit:</b> Enable Redirect->Enabled still must be unchecked however

So maybe you just want to push it to Gerrit? See http://wiki.typo3.org/Git

@Martin: I don't see why your change should fix a broken redirect... $this->redirectUrl is not changed in any of the blocks, so if the URL really is empty at that point, this won't change.

@all review: I consider this closed - a fix for the wrong label has been committed with 67fc92d906290b5898a9504b457dea68a95ac2a6 in March already. Please check with the latest (!) 4.5 version again and report back if the problem persists. Also remember to update your translations if you don't use English, as the label was changed!

A little push to Gerrit would be nice. :)

Open for a long time after requesting a patch. Setting to closed because there is no activity.