Bug #31718
closed
Javascript Error in FE
Added by Stefan Galinski over 12 years ago. Updated over 6 years ago.
100%
Description
At least Google Chrome v15 throws this exception with the javascript code from the workpaces extension in the frontend if a logged-in backend user has selected a non-live workspace. Maybe a try..catch around this statement helps if this fixes another issue within other browsers?
Uncaught Error: SECURITY_ERR: DOM Exception 18
// having this is very important, otherwise the parent.resize call will fail
document.domain = '';
Files
| 31718.diff (1.58 KB) 31718.diff | Stefan Galinski, 2011-11-10 23:17 |
Updated by Benni Mack over 12 years ago
- Status changed from New to Accepted
hey stefan,
I think a try catch issue is completely reasonable. Care to fix that?
All the best,
Benni.
Updated by Stefan Galinski over 12 years ago
- File 31718.diff 31718.diff added
Patch is tested succesfully in Chrome, but please be aware that the problem only arises if you have no configured domain. Otherwise the result won't be empty. The try..catch statement itself should work in all current browsers.
Updated by Stefan Neufeind over 12 years ago
I read that this exception just happens if the domain is empty, right? So can't we simply drop that line in case of an empty backendDomain? I see that in the template it says having this line is "very important" - but can it be important if the domain is empty? At least for chrome it seems to fail anyhow because of the exception it triggers.
PS: The line saying "having this is very important" in the template comes from a commit by tolleiv.
Updated by Stefan Neufeind over 12 years ago
- Status changed from Accepted to Needs Feedback
Asked tolleiv for feedback (via email) if having a line trying to set an empty domain makes sense anyhow.
Updated by Tolleiv Nietsch over 12 years ago
Well better figure out why this is empty sometimes ;) ... in general this could be left out.-
Updated by Stefan Neufeind over 12 years ago
- Status changed from Needs Feedback to Accepted
Updated by Stephen Bungert almost 12 years ago
I have this error in FF when logged in the BE and then opening the site. But this site does have a domain record... infact several.
Updated by Stephen Bungert almost 12 years ago
I don't know if it is connected, but there is no red preview div visible anymore, so you have no idea that you are looking at the draft site. On several occasions my boss thought I had changed the live site, after investigation it turned out that he was looking at the draft site but couldn't tell because of the missing red warning div and the button to switch to the live site was also gone.
Updated by Andreas Kiessling almost 12 years ago
I have the same JS error after opening a preview link that is generated through the backend module (in 4.7). The "workspaces.backend_domain" seems to be loaded from the BE_USER session.
@Stefan: The preview box was removed here: https://review.typo3.org/#/c/1003/
But the functionality was supposed to be implemented in the workspaces extension? http://forge.typo3.org/issues/13571 and http://forge.typo3.org/issues/12075
Updated by Jonas Enders about 11 years ago
Saving the domain entry again, solved the issue for me. (TYPO3 4.7.6)
Updated by Michael Stucki over 10 years ago
- Category changed from Labels / Error Messages to Workspaces
Updated by Michael Stucki over 10 years ago
- Project changed from 624 to TYPO3 Core
- Category changed from Workspaces to Workspaces
Updated by
Updated by Benni Mack almost 9 years ago
- Status changed from Accepted to Needs Feedback
- Is Regression set to No
Can you recheck if this problem still occurs? I think this is fixed now in 6.2.
Updated by Gerrit Code Review almost 9 years ago
- Status changed from Needs Feedback to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42394
Updated by Daniel Goerz almost 9 years ago
- Status changed from Under Review to Needs Feedback
The error still exists in 6.2 and in 7.4. I uploaded a patch that assures there always is a backend domain passed to the view.
Updated by Gerrit Code Review almost 9 years ago
- Status changed from Needs Feedback to Under Review
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42394
Updated by Gerrit Code Review almost 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42394
Updated by Gerrit Code Review over 8 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42837
Updated by Daniel Goerz over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 9fb592c3485b6b58690f44d298f84ad5e6baa018.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed