Project

General

Profile

Actions
Copy link

Feature #34922

closed

Allow .ts file extension for static typoscript templates

Added by Sebastian Michaelsen over 12 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Pierrick Caillon
Category:
-
Target version:
7.4 (Backend)
Start date:
2012-03-16
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:

Description

At the moment the following static typoscript filenames are allowed:

setup.txt
constants.txt
include_static.txt
include_static_files.txt

My intention is to also allow ".ts" as file extensions because they're commonly used and IDEs can recognize those file as TypoScript.

I was already playing around with the code and what makes me worry is performance. It's quite expensive to check all the allowed filenames and read them.

I benchmarked different situations (folder with only .txt / only .ts / both / none) and in average it slows down the reading of static templates by about 48%. I don't know if this is acceptable in change for the convenience you get.
Maybe there's a possibility for a smart caching solution or other ideas on improving the performance. Ideas are welcome.

I will add my best effort patch here shortly.

Files

34922.diff (4.96 KB) 34922.diff Sebastian Michaelsen, 2012-03-16 13:44
Actions
Copy link
 #1

Updated by Sebastian Michaelsen over 12 years ago

This is my first patch.

  • Mixed usage of .txt and .ts is allowed.
  • .ts precedes .txt
Actions
Copy link
 #2

Updated by Sebastian Michaelsen over 12 years ago

One more point on performance:

Maybe it's not as critical as 48% sounds. According to my measurements reading out the folder is in a time scale of 0,2ms up to 1,2ms. So in the worst case you will lose less than 1ms per extension template. It's still worth thinking about optimization, but not a blocker I think.

Actions
Copy link
 #3

Updated by Oliver Hader over 12 years ago

Sounds good. Once you're done with your patch, could you please add it to review.typo3.org so others can test and review it?
See http://wiki.typo3.org/Contribution_Walkthrough_Tutorials for accordant information.

Actions
Copy link
 #4

Updated by Gerrit Code Review over 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9736

Actions
Copy link
 #5

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9736

Actions
Copy link
 #6

Updated by Sebastian Michaelsen over 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Christian Kuhn over 12 years ago

  • Status changed from Resolved to New
  • TYPO3 Version changed from 4.7 to 6.0

The merge had to be reverted again :(

It seems the ts files where now in different order, and we were unable to fix this quickly.

Actions
Copy link
 #8

Updated by Joh. Feustel over 12 years ago

Also this breaks if there are includes of not loaded extensions in a sys_template record: t3lib_extMgm::isLoaded($ISF_extKey) has been removed but t3lib_extMgm::extPath($extensionKey) only works for loaded extensions.

Actions
Copy link
 #9

Updated by Philipp Gampe over 12 years ago

Ah, that was the reason ;)

Actions
Copy link
 #10

Updated by Simon Schaufelberger about 12 years ago

is somebody willing to make a better patch? that would be great!

Actions
Copy link
 #11

Updated by Stefan Neufeind about 11 years ago

Would be great to have ...

Actions
Copy link
 #12

Updated by Mathias Schreiber almost 10 years ago

  • Target version set to 7.2 (Frontend)
Actions
Copy link
 #13

Updated by Benni Mack over 9 years ago

  • Target version changed from 7.2 (Frontend) to 7.4 (Backend)
  • Sprint Focus set to On Location Sprint
Actions
Copy link
 #14

Updated by Pierrick Caillon over 9 years ago

  • Status changed from New to In Progress
  • Assignee set to Pierrick Caillon
Actions
Copy link
 #15

Updated by Pierrick Caillon over 9 years ago

I think the include_static and include_static_file files should not accept the "ts" extension as they are list of database references and folders respectively.

Actions
Copy link
 #16

Updated by Gerrit Code Review over 9 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40264

Actions
Copy link
 #17

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40264

Actions
Copy link
 #18

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40264

Actions
Copy link
 #19

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40264

Actions
Copy link
 #20

Updated by Gerrit Code Review over 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40264

Actions
Copy link
 #21

Updated by Pierrick Caillon over 9 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #22

Updated by Mathias Schreiber over 9 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions
Copy link
 #23

Updated by Simon Schaufelberger over 9 years ago

let's drink a beer on this! yeah!!!

Actions
Copy link
 #24

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF