Project

General

Profile

Actions

Bug #35172

closed

Connection timeout when parsing large number of changed records

Added by Michal Krypczyk over 12 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2012-03-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Connection timeout occurs when large number of modified records is being loaded in Workspaces module.

AJAX timeout (after 30 secods) seems to be the cause.

Some more details:
- workspace (live/draft) doesn't matter
- multiple domains in TYPO3 installation

Alosi the Depth selection is reset to Infinite when another page in pagetree is selected.


Related issues 4 (0 open4 closed)

Related to TYPO3 Core - Bug #30405: Switching Workspaces results in Connection TimeoutClosed2011-09-28

Actions
Related to TYPO3 Core - Bug #39731: Calculate percentage of differences if column is shownClosedOliver Hader2012-08-12

Actions
Related to TYPO3 Core - Bug #39727: Calculating percentage of differences is slowRejectedOliver Hader2012-08-12

Actions
Related to TYPO3 Core - Task #44189: Workspaces: Preview all for editorsClosed2012-12-21

Actions
Actions #1

Updated by Jigal van Hemert over 12 years ago

Found the cause: Tx_Workspaces_Service_GridData::calculateChangePercentage() uses similar_text() to calculate the degree of difference between the content. This function is very slow for longer strings (complexity O(N**3); N is length of longest string). For some records the time needed to calculate the change percentage took several seconds. With a few hundred records in a workspace list it would easily cause a time-out.
Limiting the strings to maximum 512 chars solves the time-outs, at least until a faster function is found.

Actions #2

Updated by Ingo Pfennigstorf over 12 years ago

@Jigal van Hemert That should not be hard to implement. Is there any use case where displaying the percentage really matters that much, that the string length cannot be cropped?

Does it work for you with a limitation to 512 chars?

Actions #3

Updated by Ingo Pfennigstorf over 12 years ago

So, why is this calculation still in workspaces?
With #11585 the display of the percentage was dropped (also see http://lists.typo3.org/pipermail/typo3-team-workspace/2011-January/000184.html
So I think that this calculation is obsolete and I'm going to write a patch for this, or did I miss something?

Actions #4

Updated by Gerrit Code Review over 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10949

Actions #5

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10949

Actions #6

Updated by Joe Schäfer over 12 years ago

Gerrit Code Review wrote:

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10949

Looks good to and works fine for me.
Fixed my issues with "connection problems".

I will report if errors/bugs occur.

Actions #7

Updated by Gerrit Code Review over 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10949

Actions #8

Updated by Ingo Pfennigstorf over 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:4141276eb63ced02f048149c7560cf883aae89be.

Actions #9

Updated by Jean-Sébastien Gervais almost 12 years ago

Sorry to revive a closed bug, but can the patch be backported to TYPO3 4.5 LTS as well?

Actions #10

Updated by Gerrit Code Review almost 12 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 4.5 has been pushed to the review server.
It is available at https://review.typo3.org/17616

Actions #11

Updated by Dan Kleine (Untenzu) almost 12 years ago

Hey, since I need this in a 4.5 version as well, I tried to make a backport of Ingos patch and pushed it to Gerrit.

Disclaimer: It's my first backport in a submodule, I hope I've satisfied all requirements.

Actions #12

Updated by Jean-Sébastien Gervais almost 12 years ago

Thank you, tested patch on a 4.5.20 instance

Actions #13

Updated by Gerrit Code Review almost 12 years ago

Patch set 2 for branch 4.5 has been pushed to the review server.
It is available at https://review.typo3.org/17616

Actions #14

Updated by Gerrit Code Review almost 12 years ago

Patch set 1 for branch 4.6 has been pushed to the review server.
It is available at https://review.typo3.org/17931

Actions #15

Updated by Gerrit Code Review almost 12 years ago

Patch set 1 for branch workspaces_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/17932

Actions #16

Updated by Gerrit Code Review almost 12 years ago

Patch set 2 for branch 4.6 has been pushed to the review server.
It is available at https://review.typo3.org/17931

Actions #17

Updated by Ingo Pfennigstorf almost 12 years ago

  • Status changed from Under Review to Resolved

Applied in changeset commit:06034536a5f3f50c30a91a6dc02e13083876809f.

Actions #18

Updated by Michael Stucki almost 11 years ago

  • Category changed from Bugs to Workspaces
Actions #19

Updated by Michael Stucki almost 11 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
Actions #20

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF