Bug #39798
closed
Story #82206: list module enhancements/bugfixes
Language and colpos changes on re-ordering of Content Elements
100%
Description
If content elements on a page are moved up and down in the order, they get the sys_language_uid assigned of the record that they jumped over.
Steps to reproduce:¶
- go to the list module (extended view + localization view active)
- create a page
- add a content element, name it "foo" and assign it the language "all languages"
- add a second content element, name it "bar" and leave it on language "default"
The list now looks like this:
- foo - all languages
- bar - default
Now click the arrow down, to move "foo" down after "bar". Expected result is that only the order changes. But now, the order changes AND the language "default" will also be set for "bar", resulting in the following list:
- foo - default
- bar - default
Notes:¶
- Disabling the Localization View has no effect -> bug is reproducable independent of that checkbox
- Same mistake happens in the Page Module
Updated by Steffen Gebert over 12 years ago
- Status changed from New to Needs Feedback
Thanks for the report, Mario. Can you reproduce this with older TYPO3 versions?
Updated by Mario Rimann over 12 years ago
Steffen Gebert wrote:
Can you reproduce this with older TYPO3 versions?
I did not explicitely test it today in older versions, but my colleague who found this issue in a customer project is working in a 4.5.x environment - so I'm pretty sure it's also reproducable in 4.5.x and up to master (tested with a 6.0-dev today).
Updated by Steffen Gebert over 11 years ago
- Status changed from Needs Feedback to New
Updated by Markus Klein over 11 years ago
Hi!
Can you please check whether there is a hook registered for:
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tcemain.php']['moveRecordClass']
You can use the Configuration module in the BE for checking that.
Thx.
Updated by Mario Rimann over 11 years ago
Markus Klein wrote:
Can you please check whether there is a hook registered for:
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tcemain.php']['moveRecordClass']
On the installation where this was reported, the "multicolumn" extension is installed, which adds itself to exactly this hook. So I went to test it on another 4.5.x based setup, where multicolumn is not installed. So the only thing that is hooked into the mentioned hook (in both installations) is:
EXT:cms/tslib/hooks/class.tx_cms_treelistcacheupdate.php:&tx_cms_treelistCacheUpdate
The issue is reproducable also in this setup with only this hook in place.
Updated by Mario Rimann about 11 years ago
I just tried to reproduce this as an editor user on a TYPO3 v6.1.5 installation -> error appears also in this situation.
Updated by Markus Klein about 11 years ago
- Category set to Backend API
- Status changed from New to Accepted
- Priority changed from Should have to Must have
- Target version set to next-patchlevel
- Complexity set to hard
- Is Regression set to No
I can reproduce this on current master (6.2) too. Strangely this only happens when moving things "down"!
Updated by Mathias Schreiber almost 10 years ago
- Target version changed from next-patchlevel to 7.4 (Backend)
Updated by Susanne Moog over 9 years ago
- Target version changed from 7.4 (Backend) to 7.5
Updated by Benni Mack about 9 years ago
- Target version changed from 7.5 to 7 LTS
Updated by Mathias Schreiber about 9 years ago
- Category changed from Backend API to DataHandler aka TCEmain
- Target version deleted (
7 LTS)
Updated by Markus Klein over 7 years ago
- Subject changed from Language changes on re-ordering of Content Elements to Language and colpos changes on re-ordering of Content Elements
- Target version set to Candidate for patchlevel
- Complexity changed from hard to medium
Can be reproduced in all versions independent of any third party extension.
The problem is that \TYPO3\CMS\Core\DataHandling\DataHandler::fixCopyAfterDuplFields() being called on a move command.
Specifically, when you have a CE list like that (list module):
- Title1 (colPos = 0)
- Title2 (colPos = 2)
- Title3 (colPos = 2)
If one clicks the up-button to move Title3 before Title2, the colPos AND sys_language_uid of Title3 is being set to zero.
=> Hence, it shows up below Title1, but in the wrong column
Updated by Riccardo De Contardi almost 7 years ago
- Related to Bug #14873: CE jumps from right to normal when moved in list mode added
Updated by Riccardo De Contardi over 6 years ago
- Related to Bug #72988: losing Localization when moving elements (Typo 7.6.2) added
Updated by Christian Eßl over 4 years ago
- Related to Bug #59901: Move records in list module kills sys_language_uid added
Updated by Gerrit Code Review over 4 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63646
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63646
Updated by Gerrit Code Review over 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63646
Updated by Gerrit Code Review over 4 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63646
Updated by Gerrit Code Review over 4 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63646
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64137
Updated by Christian Eßl over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset acff9da490244cd405a4ae12eb7f034a3b39cfb6.