TYPO3 Core

Thanks for your patch, Alexander. Could you push this into the review workflow?

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/14126

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/14127

What else needs to be done to get that merged?

Christian Weiske wrote:

What else needs to be done to get that merged?

See my comment at the 4.7 patchset and the general workflow description http://wiki.typo3.org/Gerrit_Review_Workflow

In general: if your commit message is good, and you code is understandable people will more likely review your Code. If it's not clear what happens, everybody just jumps to the next review request - there are plenty and more one can deal with.

A testing howto is helpful to - don't be shy to write long commit messages

And as you need at least one core review - the patch cannot be merged by just reviewing it with 2 collegues.

"And as you need at least one core review" - Thats known and we wait for that.

Why I should write the complete bug text into the commit message? Do I need to write down how to clean the cache and where the cached localconf file is?

hey Alex,

could you give me an example on how such an extension file could look like with the declare() statement? I have never seen one and I'd like to reproduce the issue :)

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/14125

Patch set 3 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/14125

Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at https://review.typo3.org/14126

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/14127

Thanks for the patch. However I'm against introducing such things, but instead document that declare encoding is not allowed in ext_tables.php and ext_localconf.php files unless you have strong arguments why declare encoding statements are mandatory in these files.

Helmut Hummel wrote:

However I'm against introducing such things, but instead document that declare encoding is not allowed in ext_tables.php and ext_localconf.php files unless you have strong arguments why declare encoding statements are mandatory in these files.

Agree with Helmut. According to CGL "All TYPO3 source files use the UTF-8 character set without byte order mark (BOM) since version 4.5.", so there is no need to declare any encoding (both in core and extensions). I'd even go a step further and declare it as not allowed in any PHP file in TYPO3.

Wont be done http://forum.typo3.org/index.php?t=msg&th=194610&goto=676136&#msg_676136