Bug #49803
closed
Problems in overriding objects with new property mapper
Added by Georg Ringer over 11 years ago.
Updated about 6 years ago.
Description
It seems there is a problem with overriding objects when using the new property mapper.
check this code
config.tx_extbase {
objects {
GeorgRinger\Testoverride\Domain\Model\Fo {
className = GeorgRinger\Testoverride\Domain\Model\Bar
}
}
}
if the model is used as argument, the "overlay" of Model Bar
is missing.
A simple demo extension can be found at: http://montagmorgen.at/fileadmin/tmp/testoverride_0.0.0.zip
Important: the demo exts deactivates the new property mapper in ext_typoscript_setup.txt
.
Proof of concept:
- Install extension and add plugin to a page
- Create a new record in the FE and fill all fields
- Disable the new property mapper and add a 2nd record
- Exception "#1297759968: Exception while property mapping at property path "":Property "test" was not found in target object of type "GeorgRinger\Testoverride\Domain\Model\Fo"." should be shown.
Files
- Status changed from New to Under Review
Ok, had a deeper look at this.
What I don't get, is, why you get a Exception from the rewritten PropertyMapper, but you disabled it.
Also I'm not sure, if objectManagers registerImplemenation is build also for extending models. This will definitly break also in other parts.
Regarding the feature you break with this patch, the backported #30300 - setting a subtype by __type - I would say, this is exactly what you need. But to make this work the function allowOverrideTargetType in MvcPropertyMappingConfiguration is missing ATM.
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31920
- Project changed from 534 to TYPO3 Core
- Category set to Extbase
- TYPO3 Version set to 6.2
- Is Regression set to No
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31920
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33327
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
This change should also allow for using interfaces in controller action arguments if an implementation is registered as usual. Previously the type converter tried to create an instance of the interface.
- Status changed from Resolved to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33330
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33331
- Status changed from Under Review to Resolved
- Status changed from Resolved to Closed
Also available in: Atom
PDF