TYPO3 Core

Found a small problem in my patch.

Hi,

was this issue fixed or does it still exists?

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35328

can someone please verify this issue is still valid? I am under the impression it was solved meanwhile.

This ticket has been rejected since the DataMapper must never use the repository settings, especially since the DataMapper can can be called in different contexts. We are dealing with the backend here and it's the responsibility of the user to create custom queries that respect deleted/hidden in a custom way. The default is that Extbase does not apply enable fields in the backend for good reasons.

Alexander Schnitzler wrote:

This ticket has been rejected since the DataMapper must never use the repository settings, especially since the DataMapper can can be called in different contexts. We are dealing with the backend here and it's the responsibility of the user to create custom queries that respect deleted/hidden in a custom way. The default is that Extbase does not apply enable fields in the backend for good reasons.

Hi,

I just stumbled across this issue in a custom TYPO3 backend controller, where in the model repository I try to fetch some records with visibility dates set.
This is my code.

    /**
     * @param $electionUid
     * @return object
     */
    public function findByUidIgnoreEnableFields($electionUid) {

        /** @var $querySettings \TYPO3\CMS\Extbase\Persistence\Generic\Typo3QuerySettings */
        $querySettings = $this->createQuery()->getQuerySettings();
        $originalQuerySettings = $querySettings;

        // define the enablecolumn fields to be ignored
        // if nothing else is given, all enableFields are ignored
        $querySettings->setIgnoreEnableFields(TRUE);

        // define single fields to be ignored
        $querySettings->setEnableFieldsToBeIgnored(array('disabled','starttime','endtime'));

        $this->setDefaultQuerySettings($querySettings);

        $result =  $this->findByUid($electionUid);

        // reset query settings to original state
        $this->setDefaultQuerySettings($originalQuerySettings);

        return $result;

    }

The entity with the ID I ask for exists but the query returns null because 'endtime' is in the past.
And the reason is exactly what the OP described.

The code above worked in TYPO3 7 but it stopped working in TYPO3 8.

I can not really follow the statement "We are dealing with the backend here and it's the responsibility of the user to create custom queries".
I can remember the fact, that we can use almost the same extbase controller (except where TSFE is used of course) in frontend and in backend, being praised as a great feature of extbase and recent TYPO3 backend core.

How I understand you statement is that we should be limited to raw/custom queries in backend module controllers.
Is it correct?

I do not find it obvious to always keep in mind in which context we are, to be allowed to use built in repository methods like -findByUid() or ->findAll().