Bug #75400
closed
Related child elements don't get correct sys_language_uid during localization of parent record
Added by Jan-Michael Loew over 8 years ago. Updated about 6 years ago.
100%
Description
When trying to copy Content Elements with inline relations (e.g. Image Elements, also happens with Gridelements), the inline relations are not translated.
Files
| Bildschirmfoto 2016-04-25 um 17.53.03.png (51.1 KB) Bildschirmfoto 2016-04-25 um 17.53.03.png | Birger Stöckelmann, 2016-04-25 18:02 |
Updated by Mathias Brodala over 8 years ago
Notice that this refers to the "Copy" mode for content translation. Thus basically the content element is copied with the target language set, but none of its "children" is.
Updated by Jo Hasenau over 8 years ago
- Subject changed from Inline Relations not translated on copy of Content Element to Related child elements don't get correct sys_language_uid during localization of parent record
- Category set to Localization
- Priority changed from Should have to Must have
- Target version set to 7.6.3
Updated by Mathias Brodala over 8 years ago
- Target version changed from 7.6.3 to next-patchlevel
Updated by Jo Hasenau over 8 years ago
- Target version changed from next-patchlevel to 7.6.3
Basically the copy mode triggers a simple copy action for that parent element and just adds the sys_language_uid within the update array.
So while the copy action nicely cascades and copies all the related children and grandchildren, the language information will just be applied to the first level.
Updated by Mathias Brodala over 8 years ago
Why target TYPO3 7.6.3? That version was already released (currently 7.6.5), thus next-patchlevel is the only option here.
Updated by Jo Hasenau over 8 years ago
- Status changed from New to Accepted
Just didn't notice - but of course next patchlevel is correct.
Updated by Mathias Brodala over 8 years ago
- Target version changed from 7.6.3 to next-patchlevel
Alright. :-)
Updated by Jo Hasenau over 8 years ago
- Assignee set to Jo Hasenau
- Target version changed from next-patchlevel to 7.6.3
Currently we are working as a team at T3UXW16 on several translation/localization issues and we think we found a solution for this bug.
Actually there already is a method that does everything correctly and finds all related children, and actually we already use it when the user clicks on "Translate".
In this case the core will use the localize methods, which will nicely cascade through the relation chains and set everything correctly which would be still correct for the "Copy" mode, except one field.
The only difference between "Translated" and "Copied" elements is the fact, that a copy does not get an l10n_parent.
So our solution would be: We will introduce an optional parameter for the localization methods that will enable us to ignore the l10n_parent during that process.
We can stll use the same modal, the same AJAX calls and the same value arrays, but we will use localize in both cases, with the second case making use of the new parameter.
Updated by Gerrit Code Review over 8 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review over 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review over 8 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review over 8 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Birger Stöckelmann over 8 years ago
This patch is working for me (works with gridelements and their children as well) but there is still a small caveat, because elements are copied into a wrong position.
Steps to reproduce:
1. Add content elements to the page in default language
2. Translate in copy mode
3. Add another content element in default language
4. Translate again with copy
After step 4 you will see the newly copied content element in a wrong position. (TYPO3 7.6.5, patched with this patch only).
Updated by Jo Hasenau over 8 years ago
Could you please test, if the changed order happens also with the "translation" mode of the modal?
The patch makes use of the same methods but does not set the transOrigPointerField, so actually sorting should be the same.
If this is the case, we should file another issue for that problem.
Updated by Gerrit Code Review over 8 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Ralph Brugger over 8 years ago
We've had the same problem.
With gridelements, CEs that are inside a gridelement won't be translated.
They appear in the FE but noch in the BE.
We've tried patch set 5 within TYPO3 7.6.9 and now it seems to work.
Updated by Benni Mack over 8 years ago
- Target version changed from 7.6.3 to Candidate for patchlevel
Updated by Pascal Dürsteler over 8 years ago
Tried patchset 5 with 7.6.9 but could not verify this; A few elements are not copied at all or copied empty..
Updated by Gerrit Code Review over 8 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review over 8 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review over 8 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review over 8 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review over 8 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review over 8 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Ralph Brugger about 8 years ago
I've just putted some code comments to the patch set 11.
Tested this again with patch 14:
Parse error: syntax error, unexpected ':', expecting ';' or '{' in ../typo3/sysext/core/Classes/DataHandling/DataHandler.php on line 2616
protected function getUniqueCountStatement(
string $value,
string $table,
string $field,
int $uid,
int $pid
): Statement {
=> ": Statement " Does not work with PHP 5.6
Parse error: syntax error, unexpected '.' in /typo3/sysext/core/Classes/DataHandling/DataHandler.php on line 3533
$queryBuilder ->select(...$fields)
=> "...$fields" Does not work with PHP 5.6
Parse error: syntax error, unexpected '.' in /typo3/sysext/core/Classes/DataHandling/DataHandler.php on line 4955
$result = $queryBuilder
->select(...$fileFieldArr)
=> "...$fileFieldArr" Does not work with PHP 5.6
Parse error: syntax error, unexpected '.' in /data/www/sites/bst-update/shared/typo3_src/typo3_src-7.6.10/typo3/sysext/core/Classes/DataHandling/DataHandler.php on line 6606
$result = $queryBuilder
->select(...GeneralUtility::trimExplode(',', $fieldList))
=> "...GeneralUtility" Does not work with PHP 5.6
same in:
Parse error: syntax error, unexpected '.' in /typo3/sysext/core/Classes/DataHandling/DataHandler.php on line 7107
PHP Version in this ticket ist set to 5.6.
Updated by Stefan Neufeind about 8 years ago
For master (8.x) we have PHP 7.0+. So that wouldn't be a problem and I'd appreciate to make use of improved syntax-possibilities there.
For 7.6 we'll need to adapt the code - but that's doable then.
Updated by Gerrit Code Review about 8 years ago
Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review about 8 years ago
Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review almost 8 years ago
Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Anja Leichsenring almost 8 years ago
- Sprint Focus set to On Location Sprint
Updated by Gerrit Code Review almost 8 years ago
Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review almost 8 years ago
Patch set 33 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review almost 8 years ago
Patch set 34 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review almost 8 years ago
Patch set 35 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Gerrit Code Review almost 8 years ago
Patch set 36 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47645
Updated by Tymoteusz Motylewski almost 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset c9d79db5a49a2c646ca213befe18b2db50829cfe.
Updated by Gerrit Code Review almost 8 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51109
Updated by Gerrit Code Review almost 8 years ago
Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51109
Updated by Gerrit Code Review almost 8 years ago
Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51109
Updated by Gerrit Code Review almost 8 years ago
Patch set 4 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51109
Updated by Gerrit Code Review almost 8 years ago
Patch set 5 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51109
Updated by Gerrit Code Review almost 8 years ago
Patch set 6 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51109
Updated by Gerrit Code Review almost 8 years ago
Patch set 7 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51109
Updated by Tymoteusz Motylewski almost 8 years ago
- Status changed from Under Review to Resolved
Applied in changeset 7a7b7e105039644748971298a914a1a5c7819645.