Project

General

Profile

Actions

Bug #75548

closed

RTE lacks dropdown content after updating to 6.2.21

Added by Petra Neumann over 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
-
Start date:
2016-04-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

The Update to 6.2.20 introduced a bug (?) in the RTE while editing a CE containing text. When setting a link a popup opens and there the dropdown for the link style (internal, internal in new window, external, etc.) is now empty, because the select options have the <, >, " and & replaced bei the htmlentities <,>, " and &.


Related issues 13 (0 open13 closed)

Related to TYPO3 Core - Bug #75856: RTE: anchor classes are missing when inserting or editing a linkClosed2016-04-22

Actions
Has duplicate TYPO3 Core - Bug #75573: RTE linkwizard style - missing registered classesClosed2016-04-13

Actions
Has duplicate TYPO3 Core - Bug #75605: RTE: Anchor styles set in TSconfig not present in wizard since 6.2.20Closed2016-04-14

Actions
Has duplicate TYPO3 Core - Bug #75662: Cannot choose "Style" in Insert Link Popup - false htmlentitiesClosed2016-04-15

Actions
Has duplicate TYPO3 Core - Bug #75714: Link-Options in RTE are not visibleClosed2016-04-16

Actions
Has duplicate TYPO3 Core - Bug #75741: TYPO3 6.2.21: RTE will not generate a link icon.Closed2016-04-18

Actions
Has duplicate TYPO3 Core - Bug #75789: RTE link inserter does no longer show stylesClosed2016-04-19

Actions
Has duplicate TYPO3 Core - Bug #75812: Class selector in link browser is emptyClosed2016-04-20

Actions
Has duplicate TYPO3 Core - Bug #75818: RTE Anchor Classes not working in Typo3 6.2.21Closed2016-04-20

Actions
Has duplicate TYPO3 Core - Bug #75835: RTE link style class select box is brokenClosed2016-04-21

Actions
Has duplicate TYPO3 Core - Bug #75838: Anchor Classes not rendered in rtehtmlarea_wizard_element_browserClosedDaniel Goerz2016-04-21

Actions
Has duplicate TYPO3 Core - Bug #75570: Link style dropdown in RTE not working since 6.2.21Closed2016-04-13

Actions
Has duplicate TYPO3 Core - Bug #75814: RTE LinksClosed2016-04-20

Actions
Actions #1

Updated by Markus Klein over 8 years ago

Can you try 6.2.21 please?

Actions #2

Updated by Markus Klein over 8 years ago

  • Target version deleted (6.2.20)
Actions #3

Updated by Petra Neumann over 8 years ago

Still there with 6.2.21.

And sorry, it meant to read: ... replaced by the htmlentities & lt ; & gt ; & quot ; and & amp ;

Actions #4

Updated by Markus Klein over 8 years ago

  • Subject changed from RTE lacks dropdown content after updating to 6.2.20 to RTE lacks dropdown content after updating to 6.2.21
  • Status changed from New to Accepted
  • Assignee set to Markus Klein

I'll try to fix that asap. Sorry for the troubles.

Actions #5

Updated by Alexander Bigga over 8 years ago

The error ist the htmlspecialchars() in line 874 of typo3/sysext/rtehtmlarea/Classes/BrowseLinks.php. It escapes the whole <option>-Tag instead of the values inside.

See:

https://github.com/TYPO3/TYPO3.CMS/commit/c6dcf831ad123ca9c61d12c910667106a6abf031#diff-bc64991b759f02cd03e4afc23434af72R874

Actions #6

Updated by Markus Klein over 8 years ago

Thanks Alexander for digging. Can you push a patch, so your name shows up as author?

Actions #7

Updated by Oliver Heins over 8 years ago

diff -ur typo3_src-6.2.21-orig/typo3/sysext/rtehtmlarea/Classes/BrowseLinks.php typo3_src-6.2.21/typo3/sysext/rtehtmlarea/Classes/BrowseLinks.php
--- typo3_src-6.2.21-orig/typo3/sysext/rtehtmlarea/Classes/BrowseLinks.php    2016-04-12 13:11:14.000000000 +0200
+++ typo3_src-6.2.21/typo3/sysext/rtehtmlarea/Classes/BrowseLinks.php    2016-04-13 10:50:00.862585559 +0200
@@ -871,7 +871,7 @@
                             <td><label>' . $GLOBALS['LANG']->getLL('anchor_class', TRUE) . ':</label></td>
                             <td colspan="3">
                                 <select name="anchor_class" onchange="' . htmlspecialchars($this->getClassOnChangeJS()) . '">
-                                    ' . htmlspecialchars($this->classesAnchorJSOptions[$this->act]) . '
+                                    ' . $this->classesAnchorJSOptions[$this->act] . '
                                 </select>
                             </td>
                         </tr>';

htmlspecialchars() is applied to classesAnchorJSOptions in line 238 for all relevant data.

Actions #8

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47641

Actions #9

Updated by Petra Neumann over 8 years ago

First: the patch fixes the Dropdown.

However, in the onchange event handler in the select field for the style (<select name="anchor_class" ...) the && are still escaped as & amp ;& amp ; - probably the browsers do not care, but who knows. If now I remove the htmlspecialchars() in the line above the pached one (also introduced with 6.2.20)

typo3_src-6.2.21/typo3/sysext/rtehtmlarea/Classes/BrowseLinks.php:873
<select name="anchor_class" onchange="' . htmlspecialchars($this->getClassOnChangeJS()) . '">)

the && are shown correctly, but the following line
// Reset target to default if field is not displayed and class has no configured target
document.ltargetform.ltarget.value = "";

in the middle of the onchange handler has double quotes, which is bad, because it interferes with the double quotes the handler is enclosed in. The line had single quotes until 6.2.19.

Unfortunately I have no time at the moment to look into that further. :(

Edit: translated. Sorry.

Actions #10

Updated by Wouter Wolters over 8 years ago

Please post in english here.

Actions #11

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47641

Actions #12

Updated by Markus Klein over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF