Project

General

Profile

Actions

Bug #80903

closed

Relative links with old <link> syntax are not converted to <a href> in upgrade wizard and not supported in ckeditor or linkfields

Added by Patrick Lenk over 7 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Site Handling, Site Sets & Routing
Start date:
2017-04-20
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

It seems that relative links in richtext and text fields with old <link> syntax are not converted to <a href> in upgrade wizards row updater task "Scan for old "<link>" syntax in richtext and text fields and update to "<a href>"".

We have a multidomain environment with a data pool of pages. This pages are referenced in different domains (own pages with referenced contents from the data pool pages).
In the data pool there are content elements (teasers), the teasers have relative links to this pages. The teasers are also referenced in different domains.

You want to link the pages in the teasers at the same time for all domains, without linking any page to there own page id.
Here we use relative links like <a href="microsite123/>Deeplink</a>. This links are stored in database like <link microsite123/>Deeplink</link>.
The upgrade wizard task ignores this links. In frontend this links are rendered, but in ckeditor this links are not visible or not rendered from database. So the backend user doesn't know if there is a link or not.

It would be nice if the upgarde wizard taks convert this links to.

Also it would be nice if TYPO3 supports the tel: link protocol or simply allow links with tel in rte. See Issue https://forge.typo3.org/issues/80217

Thanks!


Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Epic #84726: Initiative: URL Routing Integration / Site HandlingClosedBenni Mack2018-04-15

Actions
Related to TYPO3 Core - Bug #80217: CKeditor: No valid handlers found for type: telClosedBenni Mack2017-03-09

Actions
Related to TYPO3 Core - Bug #83683: Upgrade wizard for TYPO3 8 don't migrate "<link" to "<a href" if there is no link protocolClosed2018-01-25

Actions
Actions #1

Updated by Patrick Lenk over 7 years ago

  • Subject changed from Relative links in old <link> syntax are not converted to <a href> in upgrade wizard to Relative links with old <link> syntax are not converted to <a href> in upgrade wizard
Actions #2

Updated by Patrick Lenk over 7 years ago

  • Category changed from RTE (rtehtmlarea + ckeditor) to Install Tool

Relative links like "microsite/" are also not implemented in the new link fields, but this is maybe a further issue.

Actions #3

Updated by Patrick Lenk over 7 years ago

Update: It seems that the old internal-link handling is also dropped in rte_ckeditor. Its not possible to set relative/realurl links (no aliases) to internal pages in a multidomain environment like descripted above. The old rte links are rendered in frontend via legacy link converter, but new links can not set, ckeditor or the core linkservice can not handle relative links without any url scheme.

Actions #4

Updated by Patrick Lenk over 7 years ago

  • Category changed from Install Tool to RTE (rtehtmlarea + ckeditor)
Actions #5

Updated by Patrick Lenk over 7 years ago

  • Subject changed from Relative links with old <link> syntax are not converted to <a href> in upgrade wizard to Relative links with old <link> syntax are not converted to <a href> in upgrade wizard and not supported in ckeditor or linkfields
Actions #6

Updated by Patrick Lenk over 7 years ago

Problem summary:
- old relative internal links not converted to new link syntax in ckeditor, in frontend they converted
- relative internal links are not supported in ckeditor / url linkhandler
- url linkhandler adds scheme to every link (relative internal links and external links)
- url linkhandler adds backend domain to every link without scheme
- url linkhandler adds _blank target value to every link, if extTarget is set in constants (relative internal links and external links)

Are there any plans for relative links in v8 LTS?

Actions #7

Updated by Patrick Lenk over 7 years ago

  • Category changed from RTE (rtehtmlarea + ckeditor) to Site Handling, Site Sets & Routing
  • Assignee set to Benni Mack
Actions #8

Updated by Steffen G/G about 7 years ago

When will this bug be fixed? It's a must have to be able to set internal links in rte/ckeditor.

#1460629247: No valid handlers found for type: unknown
TYPO3\CMS\Core\LinkHandling\Exception\UnknownLinkHandlerException thrown in file
typo3/sysext/core/Classes/LinkHandling/LinkService.php in line 154.

Actions #9

Updated by Patrick Lenk over 6 years ago

  • PHP Version changed from 7.0 to 7.2
Actions #11

Updated by Markus Klein about 6 years ago

  • Related to Epic #84726: Initiative: URL Routing Integration / Site Handling added
Actions #12

Updated by Markus Klein about 6 years ago

  • Related to Bug #80217: CKeditor: No valid handlers found for type: tel added
Actions #13

Updated by Susanne Moog about 6 years ago

  • Sprint Focus set to On Location Sprint
Actions #14

Updated by Benni Mack over 5 years ago

  • Target version changed from next-patchlevel to Candidate for patchlevel
Actions #15

Updated by Peter Linzenkirchner almost 5 years ago

  • TYPO3 Version changed from 8 to 9

Is there any time line for this bug? In TYPO3 9 the problem got worse because the relative links in <link> vanish from the frontend completely. We do have 6 to 7.000 of such links in our installation ...

Actions #16

Updated by Susanne Moog almost 5 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions #17

Updated by Michael Christian over 4 years ago

Is there a solution for this bug? (As long as this is not resolved, I cannot update to LTS9 with ckeditor). Please allow/support relative links with ckeditor.

Actions #18

Updated by Riccardo De Contardi over 4 years ago

Is this related or even the same issue? #83683

Actions #19

Updated by Patrick Lenk over 4 years ago

Riccardo De Contardi wrote:

Is this related or even the same issue? #83683

yes

Actions #20

Updated by Riccardo De Contardi over 4 years ago

  • Related to Bug #83683: Upgrade wizard for TYPO3 8 don't migrate "<link" to "<a href" if there is no link protocol added
Actions #21

Updated by Lina Wolf over 3 years ago

  • TYPO3 Version changed from 9 to 10

The bug still exists in v10.4 when migrating from v7

Actions #22

Updated by Sybille Peters about 3 years ago

I also noticed there are still some content with <link in my site. All update wizard were executed (back when the updates were performed).

It also appears the <link> links still rendered ok in v9, but not anymore in v10 (when comparing with older copy which was created right before v10 update).

It looks like the upgrade wizard was supplied for an older version.

https://github.com/TYPO3/typo3/blob/TYPO3_8-7/typo3/sysext/install/Classes/Updates/RowUpdater/RteLinkSyntaxUpdater.php

This is not available for 10.4
https://github.com/TYPO3/typo3/blob/10.4/typo3/sysext/install/Classes/Updates/RowUpdater/RteLinkSyntaxUpdater.php

Since the functionality is already there, it might make sense to provide this as a separate extension (and fix the remaining problems which might have left some things unconverted).

Actions #23

Updated by Sybille Peters about 3 years ago

The things that did not get converted look like this:

<link http://example.de/marine-sensorsysteme>Arbeitsgruppe &quot;Marine Sensorsysteme&quot;</link>
<link http://example.de/marine-sensorsysteme>Arbeitsgruppe &quot;Marine Sensorsysteme&quot;</link>
<link http://example.de/cod>Projekt &quot;Coastal Ocean Darkening&quot;</link>
<link http://example.org>EyeOnWater: App und Datenbank</link>
<link http://example/science-strategy-publications>Positionspapier &quot;Advancing Citizen Science for Coastal and Ocean Research&quot; <br /></link>

I assume the " might have been a problem or something else which prevented the conversion.

Actions #24

Updated by Benni Mack about 3 years ago

  • Status changed from New to Closed

Yes. Unfortunately there is nothing we can do there anymore from TYPO3-Core-Community side as the Row Updater is not available anymore in TYPO3 Core v10 + v11. I don't know if the ELTS is willing to fix this, but this could be fixed in an public extension like this: https://extensions.typo3.org/extension/core_upgrader

I'm very sorry for the late answer and that we did not fix this in Core!

Actions #25

Updated by Rudy Gnodde about 3 years ago

A colleague of mine ran into this problem during an update of a 7.2 to 10.4. He copied the update wizard from 8 and implemented it in the site package for that site: https://github.com/joey-beech-it/Snippet-RteLinkSyntaxUpdater-TYPO3-V10

Actions #26

Updated by Patrick Lenk over 2 years ago

I don't know why and since when, but relative links like href="/subpage/landingpage/" seems to work again in ckeditor and TYPO3 v10.4.

Actions #27

Updated by Christian Weiske over 2 years ago

I had this problem when migrating to TYPO3 v9.5.31.
The https://github.com/joey-beech-it/Snippet-RteLinkSyntaxUpdater-TYPO3-V10 wizard did not help me.

Manual links to e.g. "privacy/#someanchor" are the ones that did not get migrated by both wizards.

Actions

Also available in: Atom PDF