Project

General

Profile

Actions

Bug #83468

closed

Custom icon for "Folder" is not shown

Added by Soren Malling over 6 years ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Pagetree
Target version:
-
Start date:
2018-01-04
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I've registered a custom icon for the "Contains" selector in "Page Properties". the code is here

if (TYPO3_MODE === 'BE') {
    /** @var \TYPO3\CMS\Core\Imaging\IconRegistry $iconRegistry */
    $iconRegistry = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Imaging\IconRegistry::class);
    $iconRegistry->registerIcon(
        'apps-pagetree-folder-contains-partnerads',
        \TYPO3\CMS\Core\Imaging\IconProvider\FontawesomeIconProvider::class,
        [
            'name' => 'rss'
        ]
    );
}

Notice it's a FontAwesome provided icon - dunno if that could cause the missing rendering of the icon

The custom icon is not being displayed in the page tree (see screenshot) but is working as identifier for ex. TCA tables.

!Screen Shot 2018-01-04 at 13.51.18.png!

Choosing the "frontend user" as "Module" gives the expected rendering of the icon, so the support for SVGIcons is working

The icons doesn't seem to be registered in the <defs> part of the pagetree, could that be a reason?

!Screen Shot 2018-01-04 at 14.00.07.png!


Files

Actions #1

Updated by Tymoteusz Motylewski over 6 years ago

you're right, FontAwesome icons are not supported yet unfortunatelly, as they are not rendered inline.
Need to think how can we support that.

Actions #2

Updated by Georg Ringer over 6 years ago

  • Status changed from New to Accepted
Actions #3

Updated by Rémy DANIEL over 4 years ago

Attached another screenshot taken on 9.5.
The fontawesome icon is correctly display except in the page tree.

Actions #4

Updated by Vasyl Mosiychuk over 4 years ago

I have the same problem with the custom icons for the custom of the page type

Actions #5

Updated by Henrik Elsner about 2 years ago

i got the same issue with v10

Actions #6

Updated by Benni Mack over 1 year ago

Hey everyone,

I tried to reproduce this with v11 LTS and v12.

This is what I have:

EXT:my_ext/Configuration/Icons.php

<?php

return [
    'apps-pagetree-folder-contains-partnerads' => [
        'provider' => \TYPO3\CMS\Core\Imaging\IconProvider\SvgIconProvider::class,
        'source' => 'EXT:redirects/Resources/Public/Icons/mimetypes-x-sys_redirect.svg',
    ],
];

EXT:my_ext/Configuration/TCA/Overrides/my_module.php

<?php

$GLOBALS['TCA']['pages']['ctrl']['typeicon_classes']['contains-partnerads'] = 'apps-pagetree-folder-contains-partnerads';
$GLOBALS['TCA']['pages']['columns']['module']['config']['items'][] = ['Partner Ads', 'partnerads', 'apps-pagetree-folder-contains-partnerads'];

I also attached a screenshot on how it looks... Did I miss something?

Actions #7

Updated by Wolfgang Klinger over 1 year ago

@Benni Mack yes, that this ticket is about FontawesomeIconProvider ;)

Actions #8

Updated by Christian Kuhn 7 months ago

  • Status changed from Needs Feedback to Closed

Hey. I hope it is ok to close here: FontawesomeIconProvider has been removed in v12, and we will most likely not change anything in v11 in this area anymore. Feel free to re-open or re-discuss in case we bissed something.

Actions

Also available in: Atom PDF