Project

General

Profile

Actions
Copy link

Bug #83468

closed

Custom icon for "Folder" is not shown

Added by Soren Malling almost 7 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Pagetree
Target version:
-
Start date:
2018-01-04
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I've registered a custom icon for the "Contains" selector in "Page Properties". the code is here

if (TYPO3_MODE === 'BE') {
    /** @var \TYPO3\CMS\Core\Imaging\IconRegistry $iconRegistry */
    $iconRegistry = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Imaging\IconRegistry::class);
    $iconRegistry->registerIcon(
        'apps-pagetree-folder-contains-partnerads',
        \TYPO3\CMS\Core\Imaging\IconProvider\FontawesomeIconProvider::class,
        [
            'name' => 'rss'
        ]
    );
}

Notice it's a FontAwesome provided icon - dunno if that could cause the missing rendering of the icon

The custom icon is not being displayed in the page tree (see screenshot) but is working as identifier for ex. TCA tables.

!Screen Shot 2018-01-04 at 13.51.18.png!

Choosing the "frontend user" as "Module" gives the expected rendering of the icon, so the support for SVGIcons is working

The icons doesn't seem to be registered in the <defs> part of the pagetree, could that be a reason?

!Screen Shot 2018-01-04 at 14.00.07.png!

Files

Download all files
Screen Shot 2018-01-04 at 13.51.18.png (248 KB) Screen Shot 2018-01-04 at 13.51.18.png Soren Malling, 2018-01-04 13:53
Screen Shot 2018-01-04 at 14.00.07.png (130 KB) Screen Shot 2018-01-04 at 14.00.07.png Soren Malling, 2018-01-04 14:00
Sélection_997.png (20.1 KB) Sélection_997.png Rémy DANIEL, 2019-12-06 18:52
Screenshot 2022-11-03 at 21.18.05.png (48.9 KB) Screenshot 2022-11-03 at 21.18.05.png Benni Mack, 2022-11-03 20:20
Actions
Copy link
 #1

Updated by Tymoteusz Motylewski almost 7 years ago

you're right, FontAwesome icons are not supported yet unfortunatelly, as they are not rendered inline.
Need to think how can we support that.

Actions
Copy link
 #2

Updated by Georg Ringer almost 7 years ago

  • Status changed from New to Accepted
Actions
Copy link
 #3

Updated by Rémy DANIEL almost 5 years ago

Attached another screenshot taken on 9.5.
The fontawesome icon is correctly display except in the page tree.

Actions
Copy link
 #4

Updated by Vasyl Mosiychuk almost 5 years ago

I have the same problem with the custom icons for the custom of the page type

Actions
Copy link
 #5

Updated by Henrik Elsner over 2 years ago

i got the same issue with v10

Actions
Copy link
 #6

Updated by Benni Mack about 2 years ago

Hey everyone,

I tried to reproduce this with v11 LTS and v12.

This is what I have:

EXT:my_ext/Configuration/Icons.php

<?php

return [
    'apps-pagetree-folder-contains-partnerads' => [
        'provider' => \TYPO3\CMS\Core\Imaging\IconProvider\SvgIconProvider::class,
        'source' => 'EXT:redirects/Resources/Public/Icons/mimetypes-x-sys_redirect.svg',
    ],
];

EXT:my_ext/Configuration/TCA/Overrides/my_module.php

<?php

$GLOBALS['TCA']['pages']['ctrl']['typeicon_classes']['contains-partnerads'] = 'apps-pagetree-folder-contains-partnerads';
$GLOBALS['TCA']['pages']['columns']['module']['config']['items'][] = ['Partner Ads', 'partnerads', 'apps-pagetree-folder-contains-partnerads'];

I also attached a screenshot on how it looks... Did I miss something?

Actions
Copy link
 #7

Updated by Wolfgang Klinger about 2 years ago

@Benni Mack yes, that this ticket is about FontawesomeIconProvider ;)

Actions
Copy link
 #8

Updated by Christian Kuhn about 1 year ago

  • Status changed from Needs Feedback to Closed

Hey. I hope it is ok to close here: FontawesomeIconProvider has been removed in v12, and we will most likely not change anything in v11 in this area anymore. Feel free to re-open or re-discuss in case we bissed something.

Actions
Copy link

Also available in: Atom PDF