Bug #86935

Cannot fetch 404 page with simple base

Added by Mathias Brodala over 2 years ago. Updated 6 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Start date:
2018-11-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you set up the errorHandling in a site configuration to use the errorHandler: Page and a dedicated page as errorContentSource this page cannot be displayed if you use a base without a full URL like / or /en/ (for language variants)

The following error is displayed as HTML response in this case:

Error handler could not fetch error page: Possible recursion detected.

There are many problems with this error message itself:

  • It does not contain the internally resolved URL
  • It does not contain the exact error message which occurred

In this very case a errorContentSource like t3://page?uid=10 is resolved to /404 (if that's the slug of the 404 page) by the PageContentErrorHandler. Then GeneralUtility::getUrl() tries to load this as a file called /404 in the filesystem of the web server since the resolved URL does not contain a scheme and host. At least this additional error could be avoided by using the RequestFactory directly.

The error itself should be fixed by prepending the current scheme and host in case the resolved URL is not a full URL. The PageContentErrorHandler only supports pages and full URLs anyways. This could make it necessary to add an additional StaticFileErrorHandler to cover cases where displaying content of a static file really was intended.


Related issues

Related to TYPO3 Core - Task #87073: Optimize error message of handlePageError()ClosedPeter Kraume2018-12-04

Actions
Related to TYPO3 Core - Bug #86616: Content of 404 page is not shownClosed2018-10-10

Actions
Related to TYPO3 Core - Bug #86260: Site error handling: Show content from page with / entry pointClosed2018-09-15

Actions
Related to TYPO3 Core - Feature #88361: Site error handling: "Show content from page" for 404 should render page directlyAccepted2019-05-15

Actions
#1

Updated by Peter Kraume over 2 years ago

  • Related to Task #87073: Optimize error message of handlePageError() added
#2

Updated by Wolfgang Wagner over 2 years ago

Problem still exists in 9.5.3

#3

Updated by Benjamin Schmidt over 2 years ago

Problem still exists in 9.5.3 - i can confirm.
Workaround: Just point to your 404 page by URL, this works.

#4

Updated by Christian Hackl about 2 years ago

Benjamin Schmidt wrote:

Problem still exists in 9.5.3 - i can confirm.
Workaround: Just point to your 404 page by URL, this works.

and how do you do this?
(TYPO3 9.5.4)

#5

Updated by Mathias Brodala about 2 years ago

Christian Hackl wrote:

Benjamin Schmidt wrote:

Problem still exists in 9.5.3 - i can confirm.
Workaround: Just point to your 404 page by URL, this works.

and how do you do this?
(TYPO3 9.5.4)

Use a full URL like https://example.org/404 and use environment variables if necessary.

#6

Updated by Christian Hackl about 2 years ago

Mathias Brodala wrote:

Christian Hackl wrote:

Benjamin Schmidt wrote:

Problem still exists in 9.5.3 - i can confirm.
Workaround: Just point to your 404 page by URL, this works.

and how do you do this?
(TYPO3 9.5.4)

Use a full URL like https://example.org/404 and use environment variables if necessary.

Ah thanks

#7

Updated by Niklas Lazinbee about 2 years ago

The Problem still exists in 9.5.5

Just point to your 404 page by URL

This don't work for me?

#8

Updated by Attila Glück about 2 years ago

hi, you must set a full base url in config.yaml https://domain.com/ than works.

#9

Updated by Niklas Lazinbee about 2 years ago

Okay, the problem is, I protected the website width htacess password. Without the protection the solution with the url works.

#10

Updated by Riccardo De Contardi about 2 years ago

Are these issues related?

#86616

#86260

#11

Updated by Mathias Brodala about 2 years ago

Riccardo De Contardi wrote:

Are these issues related?

#86616

#86260

Yes, sounds like, please mark them accordingly.

#12

Updated by Riccardo De Contardi about 2 years ago

  • Related to Bug #86616: Content of 404 page is not shown added
#13

Updated by Riccardo De Contardi about 2 years ago

  • Related to Bug #86260: Site error handling: Show content from page with / entry point added
#14

Updated by Alexander Grein about 2 years ago

Is it also possible to show 404 pages for different languages using the absolute url trick?

#15

Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60630

#16

Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60630

#17

Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60630

#18

Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60630

#19

Updated by Benni Mack about 2 years ago

  • Target version changed from next-patchlevel to Candidate for patchlevel
#20

Updated by Stefan Neufeind almost 2 years ago

  • Related to Feature #88361: Site error handling: "Show content from page" for 404 should render page directly added
#21

Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60630

#22

Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60630

#23

Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60873

#24

Updated by Andreas Fernandez almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#25

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
#26

Updated by Martin Hotmann 6 months ago

Andreas Fernandez wrote in #note-24:

Applied in changeset c4a144e6c2d3c2e5c457290ca36fd3331a6d6c77.

Same Bug in TYPO3 v10.4.9 for me right now

#27

Updated by Mathias Brodala 6 months ago

Martin Hotmann wrote in #note-26:

Andreas Fernandez wrote in #note-24:

Applied in changeset c4a144e6c2d3c2e5c457290ca36fd3331a6d6c77.

Same Bug in TYPO3 v10.4.9 for me right now

You can avoid the issue (and considerably increase performance) by installing the pixelant/pxa-lpeh package. This turns the 404 handling into a completely internal request.

Also available in: Atom PDF