Bug #25434
closed
Workspace state change notification email is always in english
Added by Alban Cousinie about 13 years ago. Updated over 5 years ago.
100%
Description
When a user sends a content element to next validation stage using the workspace module, the notification email sent to all the people subscribed to the stage is always in English, even though that part of the extension is properly / fully translated and downloaded on the local server (using french localized version of the extension "version").
So it looks like the current user BE language is ignored.
Updated by Oliver Hader about 13 years ago
- Target version changed from 4.5.1 to 4.5.3
Updated by Oliver Hader about 13 years ago
- Target version changed from 4.5.3 to 4.5.3
Updated by Oliver Hader about 13 years ago
- Target version changed from 4.5.3 to 4.5.3
Updated by
Updated by Tolleiv Nietsch almost 13 years ago
- Target version changed from 4.5.3 to 4.5.4
- TYPO3 Version set to 4.5
Updated by Andreas Kiessling over 12 years ago
This probably happens due to how the receivers of the mail are set: notificationAlternativeRecipients from the ActionHandler only sets info about the mail addresses, not about any language params.
Additional problems with the mail: the stage title is fetched from Tx_Workspaces_Service_Stages. But that way, the title is always in the language of the user that initiated that process. The localized text is built much later in an extra language object. So right now you get a mixed up mail with a probably wrongly localized title and an english bodytext.
While i really like to be able to localize the mail, i have some usability concern about the current implementation:
each mail is sent on its own to deliver the localized mail. But how does the receiver/reviewer know, who else got the notification mail? If the be_user who initiates a review process can even uncheck recipients, there should also be a marker that lists all of the recipients. Before that feature, the mail just had multiple recipients so any further communication for the review could be done by just replying to the mail. Maybe all of the receivers can be set as replyTo then?
Updated by Tolleiv Nietsch over 12 years ago
- Status changed from New to Accepted
- Target version changed from 4.5.4 to 4.7.0
True - still a breaking change which has to wait for 4.7
Updated by Andreas Kiessling over 12 years ago
Hi Tolleiv,
- my usability concern: agreed - I will open a new issue for that. Target >= 4.7
- the original post from Alban is imho a bug (+ the wrongly localized title) which should be fixed in >= 4.5
see #23752 for the original feature request
Updated by Dennis Ahrens over 12 years ago
Currently notifyStageChange inside the tcemain hook class respects that lang is set for the users email. But the Tx_Workspaces_ExtDirect_ActionHandler->getRecipientList that processes all recipients before never hand over the lang information. I gues thats the reason why english is used all the time.
Updated by
Updated by Xavier Perseguers almost 12 years ago
- Assignee deleted (
Steffen Ritter)
The problem is in fact that the processed list of recipients (btw nasty typo in tx_Workspaces_ExtDirect_ActionHandler, getSendToStageWindow() does getReceipientsOfStage() <-- getRecipientsOfStage should be the correct name.
This is only contains the email address, not the language of the user. Furthermore, this list is passed to version_setStage in EXT:version, implementation of the TCEMAIN hooks and finally to protected method notifyStageChange which is able to cmopile the list of recipients if none has been given. But the list is always populated with the email addresses of the addresses. It does that:
foreach ($notificationAlternativeRecipients as $emailAddress) {
$emails[] = array('email' => $emailAddress);
}
and furthermore line 586, the 'lang' attribute is searched for to localize the email. But this attribute is not set and CANNOT be set since the new feature allowing the editor to self choose the recipients of the notification message has been added. As such this is some part of the code that cannot accessed anymore (at least it seems so !)
Since these are protected methods, I'd say that we should be able to do it better and send be_user uids instead of email addresses to the ExtJS dialog. And process the selected uids to populate both the email and the lang field, the rest should be kept as this.
Another option would be to have a switch to prevent the user from self selecting who is receiving the notification email and let the website administrator decide of the actual workflow without a way to be changed by some editor.
Updated by Gerrit Code Review almost 12 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10947
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10948
Updated by Gerrit Code Review almost 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10947
Updated by Gerrit Code Review almost 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10948
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch workspaces_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12044
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch version_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12045
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch 4.6 has been pushed to the review server.
It is available at http://review.typo3.org/12046
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch 4.6 has been pushed to the review server.
It is available at http://review.typo3.org/12047
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch 4.5 has been pushed to the review server.
It is available at http://review.typo3.org/12048
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch 4.5 has been pushed to the review server.
It is available at http://review.typo3.org/12049
Updated by Xavier Perseguers almost 12 years ago
- Status changed from Under Review to Resolved
Applied in changeset commit:38826d3c6c882800bc8339c448b72a9523aa56b3.
Updated by Gerrit Code Review over 11 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 4.6 has been pushed to the review server.
It is available at http://review.typo3.org/12046
Updated by Xavier Perseguers over 11 years ago
- Status changed from Under Review to Resolved
Applied in changeset commit:05d038c204489c59abb662b245ea8c699c85260c.
Updated by Gerrit Code Review over 11 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 4.5 has been pushed to the review server.
It is available at http://review.typo3.org/12048
Updated by Xavier Perseguers over 11 years ago
- Status changed from Under Review to Resolved
Applied in changeset commit:f1e00b1599db583dad4a2fb4511cfdbf4511dcd2.
Updated by Gerrit Code Review over 11 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch version_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12045
Updated by Marco Bresch over 11 years ago
- Status changed from Under Review to Resolved
Updated by Michael Stucki over 10 years ago
- Category changed from Workspace notifications to Workspaces
Updated by Michael Stucki over 10 years ago
- Project changed from 624 to TYPO3 Core
- Category changed from Workspaces to Workspaces
Updated by