Project

General

Profile

Actions

Bug #29221

closed

Sprite Manager and Icon Works are creating invalid class names

Added by Jo Hasenau about 13 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2011-08-24
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.4
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

When using the field module which is rendered as contains plugin within the TCE forms of a page you can assign your own module name.
This name is not restricted to follow any naming conventions so it can contain any character and up to 64k of data, since the DB field is a blob.

Now while creating the classes for the page tree the value of this module field is used as part of the class name in
a) the HTML output
b) the CSS file containing the styles for the icon

Now an extension using names like

my_extension:MODULE

or
my_extension:MODULE.type.TYPE

is creating a CSS selector like

.tcarecords-table-my_extension:MODULE.type.TYPE

I guess you can imagine the problem - exactly - the icon will be replaced with the fatal error icon.

We've got naming conventions for CSS classes though, so sprite manager and icon works should respect these and filter the value with an appropriate expression.

AFAIR it has been like that in 4.4.x already so this applies to all currently supported core versions.
I will come up with a patch soon.

Actions #1

Updated by Mario Rimann almost 13 years ago

  • Target version deleted (1341)

Hey Joey

Could you attach the patch you've mentioned? Or if you didn't finish it yet, attach whatever you have so far, and if it's only some pointers to me so I can try to change the code?

Actions #2

Updated by Philipp Gampe about 11 years ago

  • Status changed from New to Needs Feedback
  • Is Regression set to No

This one sticks around since long ... can you please check whether the bug still applies?

Actions #3

Updated by Alexander Opitz almost 11 years ago

  • Status changed from Needs Feedback to Closed
  • Assignee deleted (Jo Hasenau)

No feedback within the last 90 days => closing this ticket.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Actions #4

Updated by Jo Hasenau almost 11 years ago

Please reactivate this - I just forgot to take care of the patch, but I guess it still applies. At least it does for TYPO3 4.5.32 while updating a client project recently.

Actions #5

Updated by Jigal van Hemert over 10 years ago

  • Status changed from Closed to New
Actions #6

Updated by Jo Hasenau over 10 years ago

  • Assignee set to Jo Hasenau
Actions #7

Updated by Riccardo De Contardi over 9 years ago

  • Status changed from New to Needs Feedback

Jo, can you tell me if it is still valid in 6.2.x or 7 ?

Actions #8

Updated by Alexander Opitz over 9 years ago

  • Status changed from Needs Feedback to Closed
  • Assignee deleted (Jo Hasenau)

No feedback within the last 90 days => closing this issue.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Actions

Also available in: Atom PDF