Project

General

Profile

Actions

Bug #29221

closed

Sprite Manager and Icon Works are creating invalid class names

Added by Jo Hasenau over 13 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2011-08-24
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.4
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

When using the field module which is rendered as contains plugin within the TCE forms of a page you can assign your own module name.
This name is not restricted to follow any naming conventions so it can contain any character and up to 64k of data, since the DB field is a blob.

Now while creating the classes for the page tree the value of this module field is used as part of the class name in
a) the HTML output
b) the CSS file containing the styles for the icon

Now an extension using names like

my_extension:MODULE

or
my_extension:MODULE.type.TYPE

is creating a CSS selector like

.tcarecords-table-my_extension:MODULE.type.TYPE

I guess you can imagine the problem - exactly - the icon will be replaced with the fatal error icon.

We've got naming conventions for CSS classes though, so sprite manager and icon works should respect these and filter the value with an appropriate expression.

AFAIR it has been like that in 4.4.x already so this applies to all currently supported core versions.
I will come up with a patch soon.

Actions

Also available in: Atom PDF