Bug #44645
closed
Preview images don't get a new filename after overwriting with updated file
Added by Marcel Burkhalter over 11 years ago.
Updated over 6 years ago.
Category:
File Abstraction Layer (FAL)
Description
Steps to reproduce:
- Upload a file in the filelist
- Check filename of preview image (e.g.: preview_102455_4635_924f2e40ad.jpg)
- Overwrite with a file with the same filename but different file content
- Check preview filename again --> it stays the same
--> We've seen caching issues with IE9 because of this
As a workaround we added the following config in the .htaccess file:
<FilesMatch "^preview_.*\.(jpe?g|png|gif)$">
FileETag none
<ifModule mod_headers.c>
Header unset ETag
Header set Cache-Control "max-age=0, no-cache, no-store, must-revalidate"
Header set Pragma "no-cache"
Header set Expires "Wed, 11 Jan 1984 05:00:00 GMT"
</ifModule>
</FilesMatch>
This worked for the filelist: we now see the correct preview image directly after overwriting without manual browser reload or browser cache clearing.
BUT: In the list or page module we still see the old preview image until the IE9 tab has been reloaded (without the .htaccess rule we had to clear the browser cache to see the updated preview image). Of course this all works flawlessly with FF :)
- Status changed from New to Accepted
I suggest to include the timestamp or SHA1 hash in the name generation for the processed file. This should fix this and other issues around updating processed files. I'll have to check again though what is currently used for filename generation - maybe there's also a bug in there.
- Project changed from 1401 to TYPO3 Core
- Category set to File Abstraction Layer (FAL)
- Assignee set to Andreas Wolf
- Target version set to 6.0.2
- TYPO3 Version set to 6.0
This results from the filename not being adjusted in the patch for #44073. We'll have to tackle this.
- Status changed from Accepted to Under Review
- Status changed from Under Review to Needs Feedback
- Assignee deleted (
Andreas Wolf)
- Is Regression set to No
the original patch set was abendonded
- Target version deleted (
6.0.2)
Does the issue still exists? IMHO this was fixed in another issue.
I can confirm that this problem still exists in current master
- Status changed from Needs Feedback to New
- TYPO3 Version changed from 6.0 to 6.2
- Sprint Focus set to On Location Sprint
- Target version set to 7.1 (Cleanup)
"BUT: In the list or page module we still see the old preview image until the IE9 tab has been reloaded (without the .htaccess rule we had to clear the browser cache to see the updated preview image). Of course this all works flawlessly with FF :)"
This is not the case in 7.1 - behavoir is as expected.
Solution could be to calculate the hash for the preview also by the filehash.
- Status changed from New to In Progress
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36530
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36530
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36530
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36898
- Status changed from Under Review to Resolved
- Sprint Focus deleted (
On Location Sprint)
- Status changed from Resolved to Closed
Also available in: Atom
PDF