Bug #88179
closed
Meta tags and page title are unnecessarily cached in separate cache entries
Added by Helmut Hummel over 5 years ago. Updated over 4 years ago.
100%
Description
By concept for frontend rendering, the page title and meta tags are not meant to be stored in page cache to allow
non cachable plugins to modify those.
Currently both page title and meta tags are stored in separate cache entries, which violates the concept above
and unnecessarily tightly couples those code parts to the TypoScriptFrontendController and internal logic of it.
Therefore these caches should be removed.
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520
Updated by Gerrit Code Review over 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520
Updated by Guido Schmechel over 5 years ago
- Related to Bug #87683: TitleTagProvider always get the cached entry added
Updated by Helmut Hummel over 5 years ago
- Related to Bug #86234: Missing Meta Tags on Pages with *_INT objects added
Updated by Helmut Hummel over 5 years ago
- Related to Bug #87962: Incorrect cache lifetime for MetaTag Cache added
Updated by Gerrit Code Review over 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520
Updated by Gerrit Code Review over 5 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520
Updated by Gerrit Code Review over 5 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520
Updated by Gerrit Code Review over 5 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520
Updated by Gerrit Code Review over 5 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520
Updated by Gerrit Code Review over 5 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520
Updated by Gerrit Code Review over 5 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520
Updated by Gerrit Code Review over 5 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520
Updated by Gerrit Code Review over 5 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520
Updated by Gerrit Code Review over 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61061
Updated by Helmut Hummel over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset d05865f7b9f4c50432f93009510737f39709fd45.
Updated by Gerrit Code Review over 5 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61061
Updated by Helmut Hummel over 5 years ago
- Status changed from Under Review to Resolved
Applied in changeset 44fe4992172ec0e18b28bc4a24c57a5c93b74121.
Updated by Benni Mack almost 5 years ago
- Status changed from Resolved to Closed
Updated by Georg Ringer over 4 years ago
- Related to Bug #91316: MetaTagManagerRegistry instance not unique in uncached plugins added
Updated by Rémy DANIEL over 4 years ago
Updated by Helmut Hummel over 4 years ago
DANIEL Rémy wrote:
It seems that a annoying issue has been introduced with this change (at least with the backport on V9).
See #91233 and #91316
This change fixed this annoying issue (alongside others): #87683
So while before uncached plugins couldn't change the title tag, now cached plugins can't change title tags, when there are uncached objects on the page :-/
Updated by Helmut Hummel over 4 years ago
- Related to Bug #91233: Cached page title is overwritten on pages with *_INT objects added