Bug #21638
closed
IP-lock not aware of IPv6
Added by Bas v.d. Wiel over 14 years ago. Updated over 5 years ago.
100%
Description
When locking a session to an IP with less than 4 parts, the core attempts to do IPv4 things to a potentially IPv6 address.
The attached patch adds a simple check for IPv6 addresses and keeps TYPO3 from wrongly assuming IPv4. It just returns the full IP, assuming this choice will lock the session to the individual address (reproducing the default strictest behaviour for IPv4).
The patch is against class.t3lib_userauth.php, being the first actual patch I ever contributed to another project.. please go easy on me if I did it wrong. ;-)
(issue imported from #M15379)
Files
| userauth_ipv6.patch (239 Bytes) userauth_ipv6.patch | Administrator Admin, 2010-08-06 18:49 | ||
| 15379_v2.diff (565 Bytes) 15379_v2.diff | Administrator Admin, 2010-08-08 12:50 |
Updated by Steffen Gebert over 14 years ago
Hi Bas,
thanks for your patch!
I created a unified diff of your changes, which is what we need for the review process.
Could you please check this and send it to the core-team mailinglist afterwards, to integrate it into the next release of TYPO3?
Please read http://typo3.org/teams/core/core-mailinglist-rules/ and use TYPO3 4-4 and trunk as affected branches.
Thanks
Steffen
Updated by Bas v.d. Wiel over 14 years ago
Hi Steffen,
Thanks for correcting my patch. I can see how it was done, so I'll stick to this procedure next time. Reading up on core list rules now..
Best regards,
Bas
Updated by Susanne Moog over 13 years ago
- Status changed from Needs Feedback to Accepted
- Target version deleted (
0) - TYPO3 Version changed from 4.5 to 4.7
- Complexity set to medium
Updated by Markus Klein over 10 years ago
- Priority changed from Should have to Must have
- Is Regression set to No
Updated by Mathias Schreiber almost 10 years ago
- Target version set to 7.4 (Backend)
Updated by Susanne Moog over 9 years ago
- Target version changed from 7.4 (Backend) to 7.5
Updated by Gerrit Code Review over 7 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52947
Updated by Susanne Moog about 7 years ago
- Category set to Locking / Session Handling
Updated by Gerrit Code Review about 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52947
Updated by Gerrit Code Review about 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52947
Updated by Gerrit Code Review about 7 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52947
Updated by Gerrit Code Review almost 7 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52947
Updated by Gerrit Code Review almost 7 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52947
Updated by Gerrit Code Review almost 7 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52947
Updated by Gerrit Code Review over 6 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52947
Updated by Gerrit Code Review over 6 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52947
Updated by Gerrit Code Review over 6 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52947
Updated by Gerrit Code Review over 6 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52947
Updated by Gerrit Code Review over 6 years ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52947
Updated by Gerrit Code Review about 6 years ago
Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Gerrit Code Review over 5 years ago
Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Updated by Alexander Stehlik over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 399bf83c8df5d0cda4c902350e98581cb1816c51.
Updated by Benni Mack about 5 years ago
- Related to Bug #89226: Removed IPlock properties are still assigned added