Project

General

Profile

Actions

Feature #28626

closed

Refactor t3lib_div::getUrl()

Added by Philipp Gampe over 13 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
Start date:
2011-08-01
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
hard
Sprint Focus:

Description

After introducing t3lib_http_Request, we can simplify t3lib_div::getUrl.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Feature #70056: Use guzzleClosedGeorg Ringer2015-09-23

Actions
Blocked by TYPO3 Core - Feature #28344: Include HTTP Request2 for better HTTP handlingClosedPhilipp Gampe2011-07-202011-07-25

Actions
Actions #1

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change Ie645dca8b7605896b52bc0982586121cef4dd991 has been pushed to the review server.
It is available at http://review.typo3.org/3963

Actions #2

Updated by Philipp Gampe over 13 years ago

Commit message:

[FEATURE] Refactor t3lib_div::getUrl()

* Move non HTTP(S) parts of cURL into own method
* Deprecate this method
* Use t3lib_http_Request for HTTP(S) handling
* Move file handling into own method

Addionally fixed deprecation notizes and some spelling mistakes
around getUrl().

Now included left out deprecation warnings in content_default.php.

Change-Id: Ie645dca8b7605896b52bc0982586121cef4dd991
Resolves: #28626

Some more notes:
  • I do not think we should care for non HTTP(S) URLs. If anyone still needs this functionality, he should move this out of t3lib_div until TYPO3 4.8. I won't.
  • I tested this with current linkvalidator, however please point me to any spot where the code now behaves differently.
  • This should fix a bunch of known bugs/problems too.
Actions #3

Updated by Thorsten Kahler over 13 years ago

  • Status changed from New to Under Review
Actions #4

Updated by Mr. Hudson over 13 years ago

Patch set 2 of change Ie645dca8b7605896b52bc0982586121cef4dd991 has been pushed to the review server.
It is available at http://review.typo3.org/3963

Actions #5

Updated by Mr. Hudson over 13 years ago

Patch set 3 of change Ie645dca8b7605896b52bc0982586121cef4dd991 has been pushed to the review server.
It is available at http://review.typo3.org/3963

Actions #6

Updated by Xavier Perseguers over 13 years ago

  • Target version deleted (4.6.0-beta1)
  • TYPO3 Version changed from 4.6 to 4.7
Actions #7

Updated by Philipp Gampe almost 13 years ago

Please change from under review to accepted and from 4.7 to 4.8.

I have no time to work on this and feature freeze is soon.

Actions #8

Updated by Steffen Gebert almost 13 years ago

  • Status changed from Under Review to Accepted

Okay, thanks for your work Philipp! 4.8 hasn't been created in Redmine, yet, but I see no problem with having 4.7 here for the moment.

Actions #9

Updated by Ernesto Baschny over 11 years ago

  • Status changed from Accepted to Needs Feedback
  • TYPO3 Version changed from 4.7 to 6.1

I guess this hasn't been done in time for 6.0. But since we have HTTP_Request in core now, it would be a good thing to finish this for 6.1, right? What do you think, Philipp?

Actions #10

Updated by Philipp Gampe over 11 years ago

The problem is the behavior of the current function. Depending on the arguments and the environment (cURL?) it behaves totally different.

This is hard to refactor and there are many points to consider. So the discussion of the (abandoned) change.

This is still on my list, but not in focus as I consider this not to be urgent.

Actions #11

Updated by Alexander Opitz about 11 years ago

  • Status changed from Needs Feedback to Accepted
Actions #12

Updated by Mathias Schreiber almost 10 years ago

  • Target version set to 8 LTS
Actions #13

Updated by Philipp Gampe about 9 years ago

  • Assignee deleted (Philipp Gampe)
  • PHP Version changed from 5.3 to 7.0
  • Complexity changed from medium to hard
Actions #14

Updated by Alexander Opitz almost 9 years ago

  • PHP Version deleted (7.0)

This is independent of PHP version.

Actions #15

Updated by Riccardo De Contardi over 8 years ago

  • Assignee set to Benni Mack
Actions #16

Updated by Benni Mack about 8 years ago

  • Status changed from Accepted to Closed

- This is solved with the introduction of Guzzle in v8.0.
- If we want to deprecate getUrl(), we can simplify most of the calls now (just open a new ticket for that if you like)

Actions

Also available in: Atom PDF