Feature #28626
closed
Refactor t3lib_div::getUrl()
Added by Philipp Gampe almost 13 years ago. Updated over 7 years ago.
0%
Description
After introducing t3lib_http_Request, we can simplify t3lib_div::getUrl.
Updated by Mr. Hudson almost 13 years ago
Patch set 1 of change Ie645dca8b7605896b52bc0982586121cef4dd991 has been pushed to the review server.
It is available at http://review.typo3.org/3963
Updated by Philipp Gampe almost 13 years ago
Commit message:
[FEATURE] Refactor t3lib_div::getUrl() * Move non HTTP(S) parts of cURL into own method * Deprecate this method * Use t3lib_http_Request for HTTP(S) handling * Move file handling into own method Addionally fixed deprecation notizes and some spelling mistakes around getUrl(). Now included left out deprecation warnings in content_default.php. Change-Id: Ie645dca8b7605896b52bc0982586121cef4dd991 Resolves: #28626Some more notes:
- I do not think we should care for non
HTTP(S)URLs. If anyone still needs this functionality, he should move this out oft3lib_divuntil TYPO3 4.8. I won't. - I tested this with current linkvalidator, however please point me to any spot where the code now behaves differently.
- This should fix a bunch of known bugs/problems too.
Updated by Thorsten Kahler almost 13 years ago
- Status changed from New to Under Review
Updated by Mr. Hudson almost 13 years ago
Patch set 2 of change Ie645dca8b7605896b52bc0982586121cef4dd991 has been pushed to the review server.
It is available at http://review.typo3.org/3963
Updated by Mr. Hudson almost 13 years ago
Patch set 3 of change Ie645dca8b7605896b52bc0982586121cef4dd991 has been pushed to the review server.
It is available at http://review.typo3.org/3963
Updated by Xavier Perseguers almost 13 years ago
- Target version deleted (
4.6.0-beta1) - TYPO3 Version changed from 4.6 to 4.7
Updated by Philipp Gampe about 12 years ago
Please change from under review to accepted and from 4.7 to 4.8.
I have no time to work on this and feature freeze is soon.
Updated by Steffen Gebert about 12 years ago
- Status changed from Under Review to Accepted
Okay, thanks for your work Philipp! 4.8 hasn't been created in Redmine, yet, but I see no problem with having 4.7 here for the moment.
Updated by Ernesto Baschny about 11 years ago
- Status changed from Accepted to Needs Feedback
- TYPO3 Version changed from 4.7 to 6.1
I guess this hasn't been done in time for 6.0. But since we have HTTP_Request in core now, it would be a good thing to finish this for 6.1, right? What do you think, Philipp?
Updated by Philipp Gampe about 11 years ago
The problem is the behavior of the current function. Depending on the arguments and the environment (cURL?) it behaves totally different.
This is hard to refactor and there are many points to consider. So the discussion of the (abandoned) change.
This is still on my list, but not in focus as I consider this not to be urgent.
Updated by Alexander Opitz over 10 years ago
- Status changed from Needs Feedback to Accepted
Updated by
Updated by Philipp Gampe over 8 years ago
- Assignee deleted (
Philipp Gampe) - PHP Version changed from 5.3 to 7.0
- Complexity changed from medium to hard
Updated by Alexander Opitz over 8 years ago
- PHP Version deleted (
7.0)
This is independent of PHP version.
Updated by
Updated by Benni Mack over 7 years ago
- Status changed from Accepted to Closed
- This is solved with the introduction of Guzzle in v8.0.
- If we want to deprecate getUrl(), we can simplify most of the calls now (just open a new ticket for that if you like)