TYPO3 Core

I noticed the same error yesterday, thrown inside \TYPO3\CMS\Backend\Controller\BackendController->initializeCoreToolbarItems(). I've seen it on 4.7, 6.0, and 6.2 (haven't tested 4.5 or 6.1 yet). When I downgrade to PHP 5.5.5 the issue goes away.

From my initial investigation, the problem is in some way connected to using reflection and constructor arguments when creating the instance of the toolbar item. Inside initializeCoreToolbarItems, we have a call to makeInstance(), passing along $this as a constructor argument. Inside makeInstance(), reflection is used when handling arguments. At line 4179 of \TYPO3\CMS\Core\Utility\GeneralUtility we have "$instance = $reflectedClass->newInstanceArgs($constructorArguments)" which returns null. If I switch it to newInstance() instead, I get a valid object back.

That's about as far as I've made it in debugging for now, but maybe some of that info is helpful.

Same problem here on current Arch Linux:

• PHP 5.5.6
• TYPO3 6.1.5 (introduction package)

#1195126772: $toolbarItem "shortcuts" must implement interface TYPO3\CMS\Backend\Toolbar\ToolbarItemHookInterface (More information)

UnexpectedValueException thrown in file
/[...]/typo3_src-6.1.5/typo3/sysext/backend/Classes/Controller/BackendController.php in line 148.

I was looking for an explanation and never had PHP in mind :-(

Alexander

Related bug report: https://bugs.php.net/bug.php?id=66107

See also discussion in this "Tweet" (!!):

https://twitter.com/SwiftLizard/status/405419858864533504

The reference in the constructor was introduced with #17795

Chris Zepernick wrote:

The Problem does not only occur in TYPO3 Version 4.x but also 6.x...

Thanks! Helped me to fix a running TYPO3 6.1.5. The Hoster just switched to PHP 5.5.6 without telling anybody...

It seems PHP is not going to fix this in 5.5.7, though I would have expected that because it's a regression. Preliminary changelog for 5.5.7RC1:
https://github.com/php/php-src/blob/php-5.5.7RC1/NEWS

Chris Zepernick wrote:

The Bug can be avoided in this case by altering :

• typo3_src/typo3/sysext/backend/Classes/Toolbar/ToolbarItemHookInterface
• typo3_src/typo3/sysext/backend/Classes/Toolbar/ShortcutToolbarItem
• typo3_src/typo3/sysext/backend/Classes/Toolbar/LiveSearchToolbarItem
• typo3_src/typo3/sysext/backend/Classes/Toolbar/ClearCacheToolbarItem

alter: "public function __construct(\TYPO3\CMS\Backend\Controller\BackendController &$backendReference = NULL)“
to: "public function __construct(\TYPO3\CMS\Backend\Controller\BackendController $backendReference = NULL)“

• typo3_src/typo3/sysext/workspaces/Classes/ExtDirect/WorkspaceSelectorToolbarItem.php
• typo3_src/typo3/sysext/opendocs/Classes/Controller/OpendocsController.php
• typo3_src/typo3/sysext/sys_action/Classes/ActionToolbarMenu.php

Because they are using same interface.

Here is the next one:

• typo3_src/typo3/sysext/backend/Classes/Form/Element/TreeElement.php

Otherwise I'm not able to edit BE users (Fatal error: Call to a member function renderField() on a non-object in [...]/typo3_src-6.1.6/typo3/sysext/backend/Classes/Form/FormEngine.php on line 1749).

Just searching for "&$" in the core including the sysext-folder I found 1346 occurrences in version 6.1.
Some are in comments, some are for arrays, nevertheless the changed behavior of php seems being some work for TYPO3.

David Bruchmann wrote:

Just searching for "&$" in the core including the sysext-folder I found 1346 occurrences in version 6.1.
Some are in comments, some are for arrays, nevertheless the changed behavior of php seems being some work for TYPO3.

The only changes needed due to this PHP bug are with references in constructors, of which there are only ~10 occurrences in core (depends on version), of which most were already mentioned in these comments. These are all objects, so there is no functional difference when changing their reference declaration.

You can easily confirm, as well as find any offending extensions in your installation, with a simple regular expression: (?<=__construct\()(.*&.+)(?=\))

Same issue in typo3/sysext/backend/Classes/Form/Element/TreeElement.php

Some news from the PHP bug tracker:

I've reverted changes in PHP-5.5 (not in PHP-5.6 and above).

Thanks. So for now we can expect a fixed 5.5.7 some time. But we'll still need the change for 5.6+ then. Planned release for 5.6 is sometime around August 2014.

http://comments.gmane.org/gmane.comp.php.devel/82450

It's already mid-october and according to our release schedule we have to

release PHP 5.6 in 10 months from now.

Yes we indeed need a fix for TYPO3 as well. It does not make sense to pass the parameters as reference (nowadays) since we don't modify the variable in our constructors.

IMHO it is best to go with this breaking change now, before the 6.2 release.

Related work-around: https://review.typo3.org/#/c/26344/3

Markus Klein wrote:

IMHO it is best to go with this breaking change now, before the 6.2 release.

Why not completely remove the constructor from the interface? That is bad style anyway.

Timetable for PHP 5.6: https://wiki.php.net/todo/php56#timetable
alpha1 in January (so we could start testing), final in June

I have typo3 4.7.17 same problem.

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26363

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26363

PHP 5.5.7 has just been released. But if I see a fix for our problem in the changelog :-(
http://www.php.net/ChangeLog-5.php#5.5.7

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26363

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26363

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26363

another place for 4.5:
/typo3/sysext/em/classes/repository/class.tx_em_repository_utility.php

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26413

Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26414

Patch set 2 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26413

Patch set 2 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26414

Patch set 2 for branch TYPO3_4-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26416

Patch set 3 for branch TYPO3_4-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26416

Patch set 4 for branch TYPO3_4-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26416

Patch set 1 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26643

Helmut Hummel wrote:

Applied in changeset 2526bddb5b27ca832575fad809facfa39c7db225.

The changeset was removed with ab6256f from 4.5LTS and is not included anymore (and it seems no other patch that fixes the originating problem). I cherry-picked the patch and it seems to work but I wonder why it was removed without any other fix?

2014-01-17 ab6256f Revert "[TASK] Optimize speed for instantiating class with arguments" (Ernesto Baschny)
2014-01-17 2526bdd #53682 [TASK] Optimize speed for instantiating class with arguments (Helmut Hummel)

Claas Hilbrecht wrote:

2014-01-17 ab6256f Revert "[TASK] Optimize speed for instantiating class with arguments" (Ernesto Baschny)

It was reverted (only) because of a compatibility issue with PHP 5.2 (see: https://review.typo3.org/#/c/26910/)

I would be in favor of getting this in again with self:: instead of static:: for 4.5

Patch set 1 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33308

Gerrit Code Review wrote:

Patch set 1 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33308

Hello Helmut,

thanks for the really quick fix, I owe you a beer next time we meet ;)

This introduced a regression in 4.5; The change is not PHP 5.2 (!) compatible, see #62391