Bug #66473
closed
Cannot create object implementing Serializable on PHP 5.6
Added by Mathias Brodala over 9 years ago. Updated about 7 years ago.
100%
Description
Starting with PHP 5.6 classes implementing the Serializable interface are represented as C instead of O in the serialized output.
The Container::getEmptyObject method which creates objects with the unserialize hack to avoid calling the constructor thus yields an error like this:
Warning: Erroneous data format for unserializing 'Foo' in ...
Notice: unserialize(): Error at offset 13 of 15 bytes in ...
Starting with PHP 5.4 this usecase can be dealt with by ReflectionClass::newInstanceWithoutConstructor
This also needs to fixed for TYPO3 6.2 though which supports PHP 5.3, in which case checking for the Serializable interface and using C instead of O could work.
Updated by Gerrit Code Review over 9 years ago
- Status changed from New to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38765
Updated by Mathias Brodala over 9 years ago
See also this change in phpunit for a few caveats.
Updated by Mathias Brodala over 9 years ago
Maybe we should use doctrine/instantiator since apparently there are even more issues with this.
Updated by Helmut Hummel over 9 years ago
Mathias Brodala wrote:
Maybe we should use "doctrine/instantiator"
Yes, please!
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38765
Updated by Gerrit Code Review over 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38765
Updated by Gerrit Code Review over 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38765
Updated by Gerrit Code Review over 9 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38765
Updated by Mathias Brodala over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 89cbe117f4dd60e7145620d4c88a407bbe98a960.
Updated by Christian Kuhn over 9 years ago
- Status changed from Resolved to Accepted
- Target version changed from next-patchlevel to 6.2.13
master merged, now waiting for 6.2 backport.
Updated by Gerrit Code Review over 9 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39377
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39377
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39377
Updated by Gerrit Code Review over 9 years ago
Patch set 4 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39377
Updated by Mathias Brodala over 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset 169a6b2f0ea77e9d050dd8de4139ecdd72facc9d.
Updated by Michael Stucki over 9 years ago
- Status changed from Resolved to Accepted
- % Done changed from 100 to 50
This change contains an error for TYPO3_6-2, see https://review.typo3.org/#/c/39390/
After discussion with Lolli, I have reverted the change until this is fixed properly...
Updated by Gerrit Code Review over 9 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392
Updated by Gerrit Code Review over 9 years ago
Patch set 4 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392
Updated by Gerrit Code Review over 9 years ago
Patch set 5 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392
Updated by Gerrit Code Review over 9 years ago
Patch set 6 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392
Updated by Gerrit Code Review over 9 years ago
Patch set 7 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392
Updated by Gerrit Code Review over 9 years ago
Patch set 8 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392
Updated by Helmut Hummel over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 50 to 100
Applied in changeset 3e8f5c46e4c8968038acb22053ca421fec48f903.
Updated by Alexander Opitz over 9 years ago
- Status changed from Resolved to In Progress
- Target version changed from 6.2.13 to 6.2.14
Was reverted in https://review.typo3.org/#/c/40133/ so reopen.
Updated by Alexander Opitz over 9 years ago
- Target version changed from 6.2.14 to 6.2.15
Updated by Christian Kuhn over 9 years ago
- Sprint Focus set to Stabilization Sprint
Updated by Anonymous about 9 years ago
6.2.15 Released today.
Is it fixed or not?
Updated by Alexander Opitz about 9 years ago
- Target version changed from 6.2.15 to 6.2.16
No it wasn't fixed.
Updated by Gerrit Code Review about 9 years ago
- Status changed from In Progress to Under Review
Patch set 8 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/40522
Updated by Gerrit Code Review almost 9 years ago
Patch set 9 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/40522
Updated by Gerrit Code Review almost 9 years ago
Patch set 10 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/40522
Updated by Helmut Hummel almost 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset 9faa965d27ab9f6823d2ec270f00b7ffd940c1bd.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed