TYPO3 Core

I will have a look at that extension but why would it be so bad to include some functionality in the core? Or to simply make use of the orientation exif information?

At the moment you upload a portrait image (taken from iphone) and the image is displayed rotated - if the exif orientation is set it should be taken into account when creating processed images, dont you think?

IMO this should really work out of the box.

So okay - imagemagick convert is no solution - but taking the exif rotate property into account when dealing with images IS.

I think Philipp Wrann is totally right. Ignoring the orientation IS doing magic to the original file... TYPO3 core should respect the exif's

Why was this bug rejected? It is an issue how typo3 is using image magick. It should be atleast a setting in the [GFX] part of the installer. Using or developing an extension for this basic functionallity is too much....

I currently use the option [GFX][im_useStripProfileByDefault] so i can use [GFX][im_stripProfileCommand] with "-auto-orient +profile '*'" and every uploaded image will be fine.

For the record, ImageMagick is known to be much more vulnerable than GraphicsMagick and you may have a look into the code from EXT:image_autoresize how I had to handle the reorientation when using GM, this is not a simple flag as in IM. Furthermore, this is definitely magick to modify the file when uploading. Taking the EXIF orientation into account, when displaying the image, is not the same as changing the file. When you rotate the picture, you are potentially changing its quality as well, since the pattern in JPEG chunks are not the same anymore.

Long story short, there are a few easy solutions that you came with:

• Install EXT:image_autoresize
• Modify the im_useStripProfileByDefault setting which works fine if you use IM

I don't see a need to do anything else in the Core.

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48079

Setting -auto-orient alone will only partially fix this issue, because the width/height calculation for image resizing still ignores the EXIF rotation.
Replacing calls to the PHP function getimagesize with a custom function would fix the problem:

class ImageUtility
{
    /**
     * @param string $imageFile
     *
     * @return array
     */
    public static function getImageSize($imageFile)
    {
        $size = @getimagesize($imageFile);

        if ($size === FALSE) {
            return FALSE;
        }

        $exif = @exif_read_data($imageFile);

        $width = $size[ 0 ];
        $height = $size[ 1 ];

        // see: http://sylvana.net/jpegcrop/exif_orientation.html
        if (isset($exif[ 'Orientation' ]) && $exif[ 'Orientation' ] >= 5 && $exif[ 'Orientation' ] <= 8) {
            return [$height, $width];
        }

        return [$width, $height];
    }
}

I have experimented with an extension that overrides the following methods from the core:
(only replaces calls to getimagesize with the function shown above)

• \TYPO3\CMS\Core\Imaging\GraphicalFunctions->getImageDimensions
• \TYPO3\CMS\Core\Imaging\GraphicalFunctions->imageCreateFromFile
• \TYPO3\CMS\Core\Type\File\ImageInfo->getImageSizes

and the images seem to be processed correctly.

I also got caught by this. Exif rotation is applied if the corresponding flag is set in LocalConfiguration, but using such a rotated file inside of GIFBUILDER leads to wrong output dimensions. @Ruben, I tried your solution without luck, do you have any newer input on that issue?

@Markus Since posting that comment I have fixing the behavior of the image processing might not be the best solution.
(Browsers display images with an EXIF orientation incorrectly so we would have to process all those images to make sure the images are displayed properly.)

( Shameless self-advertising ahead ;-) )
However, I did create an extension that creates a button to "apply" the EXIF orientation on such images: https://github.com/bash/exif_orientation_helper

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48079

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48079

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48079

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48079

I've been considering this issue.. and from my point of view this is a task for the editors not for the CMS.. Of course it would be nice if the system supports the editors, but images are always a little sensitive topic.

It's content and it has to be verified by the Editor anyway.. I wouldn't invest more time in this.

I would reject this issue.

At least the image editing tool should offer the option to rotate images -
it is something a user would expect if a tool calls itself image "editor"
Nearly all of my editors are complaining about the missing rotation option.
(or the image editing tool should be called "cropping tool" otherwise.)

@#12 Ruben Schmidmeister
Thank you very much for your work, will have a look into that.

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48079

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48079

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48079

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48079

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48079

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48079