Bug #83079

wrong sorting of content elements when translating using non-default-language CEs as source

Added by Tobias Liebig almost 4 years ago. Updated over 1 year ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Localization
Target version:
-
Start date:
2017-11-24
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Steps to reproduce:
  • make sure you have at least two "Website language" records (sys_language) in your root node. Let's name them "A" and "B".
  • open the page modul
  • create a blank page
  • create at least three distinct content elements in the default language. Lets name them "1", "2", "3", "4"
  • choose the "Language" view in the "actionMenu" dropdown
  • create a page translation for language "A"
  • translate the content into "A" using the "translate" mode (not 'copy') * these content elements will be created in the correct order
  • create a page translation for language "B"
  • translate the content into "B" using the "translate" mode (not 'copy')
  • choose "A" as translation source for your translation when the dialog asks "Choose the language from which you want to localize the content"
  • the order for "B" will result in "1", "4", "3", "2"

What happens:
The "localize" method in \TYPO3\CMS\Core\DataHandling\DataHandler calls "getPreviousLocalizedRecordUid" to determine after which CE the new translated CE should be placed.
This works okay for the first case (using default as source), but returns a wrong value, when using another translation as source.


Related issues

Related to TYPO3 Core - Bug #30469: Sorting of localized tt_content elements is wrong after copyingClosedStanislas Rolland2011-09-30

Actions
Related to TYPO3 Core - Bug #68040: Inline localize and/or synchronize does not respect sortingUnder Review2018-03-142018-03-14

Actions
Related to TYPO3 Core - Bug #83469: Translation of translations break sorting in tt_contentClosed2018-01-04

Actions
#1

Updated by Tobias Liebig almost 4 years ago

Occurs in TYPO 8.7.8 and master.
From reading the code, it also might happen in earlier versions, too.

Patch already exists (will share it as soon as i figured out how to test it).
Tests are wip.

#2

Updated by Gerrit Code Review almost 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54750

#3

Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54750

#4

Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54750

#5

Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54750

#6

Updated by Gerrit Code Review almost 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54750

#7

Updated by Tobias Liebig almost 4 years ago

  • Related to Bug #30469: Sorting of localized tt_content elements is wrong after copying added
#8

Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54750

#9

Updated by Susanne Moog over 3 years ago

  • Related to Bug #68040: Inline localize and/or synchronize does not respect sorting added
#10

Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54750

#11

Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54750

#12

Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54750

#13

Updated by Ruben Schmidmeister over 3 years ago

This seems to be broken in TYPO3 7.6 too.
Is this going to be backported?

#14

Updated by Gerrit Code Review over 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54750

#15

Updated by Gerrit Code Review about 3 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54750

#16

Updated by Tymoteusz Motylewski about 3 years ago

  • Related to Bug #83469: Translation of translations break sorting in tt_content added
#17

Updated by Gerrit Code Review about 3 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54750

#18

Updated by Gerrit Code Review about 3 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54750

#19

Updated by Gerrit Code Review almost 3 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54750

#20

Updated by Gerrit Code Review about 2 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/54750

#21

Updated by Gerrit Code Review almost 2 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/54750

#22

Updated by Gerrit Code Review almost 2 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/54750

#23

Updated by Gerrit Code Review almost 2 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/54750

#24

Updated by Gerrit Code Review almost 2 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/54750

#25

Updated by Gerrit Code Review over 1 year ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/54750

Also available in: Atom PDF