Bug #87124

Multiple modal dialogs show HTML

Added by Markus Klein 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extension Manager
Target version:
-
Start date:
2018-12-13
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Updating extensions is not possible anymore as the content of the modal shows the HTML.

Affected versions: 8.7.21, 9.5.2

update dialog.jpg View (44.5 KB) Markus Klein, 2018-12-11 15:29

add media.jpg View (25 KB) Markus Klein, 2018-12-11 15:54

forge87124-dev-master-before.png View (39.5 KB) Josef Glatz, 2018-12-11 16:00

forge87124-dev-master-after.png View (40 KB) Josef Glatz, 2018-12-11 16:01


Subtasks

Bug #87144: "Add media by URL" shows encoded htmlClosed

Bug #87145: Pagetree drag and drop - tooltip shows encoded HTMLClosed

Bug #87146: Extension Manager > detail modal window shows encoded HTMLClosed

History

#1 Updated by Markus Klein 11 months ago

#2 Updated by Markus Klein 11 months ago

  • File add media.jpg View added
  • Subject changed from Extension Update dialog broken to Multiple modal dialogs show HTML

#4 Updated by Markus Klein 11 months ago

All usages of Modals in v7, v8 and v9 need to be checked, whether HTML code display is necessary and is passed as string to the modal method.

Broken calls are:

Modal.show(title, '<div>broken html</div>', ...);
Modal.confirm(title, '<div>broken html</div>', ...);
Modal.advanced({content: '<div>broken html</div>', ... });

Those need to be refactored to use jQuery objects like

let $content = $('<div>').text('working stuff');
Modal.show(title, $content, ...);

#5 Updated by Josef Glatz 11 months ago

also affected 9.5 / dev-master

Before

After

#6 Updated by Josef Glatz 11 months ago

  • Description updated (diff)

#7 Updated by Markus Klein 11 months ago

  • Assignee set to Markus Klein

#8 Updated by Markus Klein 11 months ago

List of affected code places

v9:

- typo3/sysext/backend/Resources/Private/TypeScript/OnlineMedia.ts:93
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeDragDrop.js:267+302+567+152
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/Main.js:260+389+429

v8:

- typo3/sysext/backend/Resources/Public/JavaScript/OnlineMedia.js:89
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/Main.js:260+462+502

#9 Updated by Pixelant Developer 11 months ago

  • Related to Bug #87144: "Add media by URL" shows encoded html added

#10 Updated by Rene Tobias Tobias 11 months ago

Markus Klein wrote:

Updating extensions is not possible anymore as the content of the modal shows the HTML.

Affected versions: 8.7.21, 9.5.2

Hey, is this also affecting FE? In some site we have empty <p> tags, for empty spaces, but in 8.7.21 there are no empty spaces...if i revert back to 8.7.19 is ok

#11 Updated by Wittkiel Gruppe 11 months ago

Rene Tobias Tobias wrote:

Hey, is this also affecting FE? In some site we have empty <p> tags, for empty spaces, but in 8.7.21 there are no empty spaces...if i revert back to 8.7.19 is ok

This should be issue #86819

#12 Updated by Riccardo De Contardi 11 months ago

  • Status changed from Accepted to Closed
  • Assignee deleted (Markus Klein)
  • Target version deleted (next-patchlevel)

All subtasks are closed, therefore I close this one for now.

Let me know if this is the wrong decision and I'll reopen it. Thank you.

Also available in: Atom PDF