TYPO3 Core

All usages of Modals in v7, v8 and v9 need to be checked, whether HTML code display is necessary and is passed as string to the modal method.

Broken calls are:

Modal.show(title, '<div>broken html</div>', ...);
Modal.confirm(title, '<div>broken html</div>', ...);
Modal.advanced({content: '<div>broken html</div>', ... });

Those need to be refactored to use jQuery objects like

let $content = $('<div>').text('working stuff');
Modal.show(title, $content, ...);

List of affected code places

v9:

- typo3/sysext/backend/Resources/Private/TypeScript/OnlineMedia.ts:93
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeDragDrop.js:267+302+567+152
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/Main.js:260+389+429

v8:

- typo3/sysext/backend/Resources/Public/JavaScript/OnlineMedia.js:89
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/Main.js:260+462+502

Markus Klein wrote:

Updating extensions is not possible anymore as the content of the modal shows the HTML.

Affected versions: 8.7.21, 9.5.2

Hey, is this also affecting FE? In some site we have empty <p> tags, for empty spaces, but in 8.7.21 there are no empty spaces...if i revert back to 8.7.19 is ok

Rene Tobias Tobias wrote:

Hey, is this also affecting FE? In some site we have empty <p> tags, for empty spaces, but in 8.7.21 there are no empty spaces...if i revert back to 8.7.19 is ok

This should be issue #86819