Project

General

Profile

Actions
Copy link

Bug #87124

closed

Multiple modal dialogs show HTML

Added by Markus Klein almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extension Manager
Target version:
-
Start date:
2018-12-13
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Updating extensions is not possible anymore as the content of the modal shows the HTML.

Affected versions: 8.7.21, 9.5.2

Files

Download all files
update dialog.jpg (44.5 KB) update dialog.jpg Markus Klein, 2018-12-11 15:29
add media.jpg (25 KB) add media.jpg Markus Klein, 2018-12-11 15:54
forge87124-dev-master-before.png (39.5 KB) forge87124-dev-master-before.png Josef Glatz, 2018-12-11 16:00
forge87124-dev-master-after.png (40 KB) forge87124-dev-master-after.png Josef Glatz, 2018-12-11 16:01

Subtasks 3 (0 open — 3 closed)

Bug #87144: "Add media by URL" shows encoded htmlClosed2018-12-13

Actions
Bug #87145: Pagetree drag and drop - tooltip shows encoded HTMLClosed2018-12-13

Actions
Bug #87146: Extension Manager > detail modal window shows encoded HTMLClosed2018-12-13

Actions
Actions
Copy link
 #2

Updated by Markus Klein almost 6 years ago

Actions
Copy link
 #4

Updated by Markus Klein almost 6 years ago

All usages of Modals in v7, v8 and v9 need to be checked, whether HTML code display is necessary and is passed as string to the modal method.

Broken calls are:

Modal.show(title, '<div>broken html</div>', ...);
Modal.confirm(title, '<div>broken html</div>', ...);
Modal.advanced({content: '<div>broken html</div>', ... });

Those need to be refactored to use jQuery objects like

let $content = $('<div>').text('working stuff');
Modal.show(title, $content, ...);
Actions
Copy link
 #6

Updated by Josef Glatz almost 6 years ago

  • Description updated (diff)
Actions
Copy link
 #7

Updated by Markus Klein almost 6 years ago

  • Assignee set to Markus Klein
Actions
Copy link
 #8

Updated by Markus Klein almost 6 years ago

List of affected code places

v9:

- typo3/sysext/backend/Resources/Private/TypeScript/OnlineMedia.ts:93
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeDragDrop.js:267+302+567+152
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/Main.js:260+389+429

v8:

- typo3/sysext/backend/Resources/Public/JavaScript/OnlineMedia.js:89
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/Main.js:260+462+502

Actions
Copy link
 #9

Updated by Pixelant Developer almost 6 years ago

  • Related to Bug #87144: "Add media by URL" shows encoded html added
Actions
Copy link
 #10

Updated by Rene Tobias almost 6 years ago

Markus Klein wrote:

Updating extensions is not possible anymore as the content of the modal shows the HTML.

Affected versions: 8.7.21, 9.5.2

Hey, is this also affecting FE? In some site we have empty <p> tags, for empty spaces, but in 8.7.21 there are no empty spaces...if i revert back to 8.7.19 is ok

Actions
Copy link
 #11

Updated by Wittkiel Gruppe almost 6 years ago

Rene Tobias Tobias wrote:

Hey, is this also affecting FE? In some site we have empty <p> tags, for empty spaces, but in 8.7.21 there are no empty spaces...if i revert back to 8.7.19 is ok

This should be issue #86819

Actions
Copy link
 #12

Updated by Riccardo De Contardi almost 6 years ago

  • Status changed from Accepted to Closed
  • Assignee deleted (Markus Klein)
  • Target version deleted (next-patchlevel)

All subtasks are closed, therefore I close this one for now.

Let me know if this is the wrong decision and I'll reopen it. Thank you.

Actions
Copy link

Also available in: Atom PDF