Project

General

Profile

Actions
Copy link

Bug #87845

closed

cacheHash.excludedParameters will be ignore when Enhancer is called

Added by Alexey Atsyn over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Site Handling, Site Sets & Routing
Target version:
Candidate for patchlevel
Start date:
2019-03-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

We detected a problem: when system called PluginEnhancer he wil call exception in the \TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController::reqCHash function.
I've checked the code and find next:
PageArguments return all query parameters not from config as is and those parameters not compare with cacheHash.excludedParameters

We wrote next patch but don;;t sure is it correct solution:

    public function reqCHash()
    {
        $skip = false;
        if ($this->pageArguments !== null) {
            /** @var \TYPO3\CMS\Frontend\Page\CacheHashCalculator $cacheHashCalculator */
            $cacheHashCalculator = GeneralUtility::makeInstance(\TYPO3\CMS\Frontend\Page\CacheHashCalculator::class);
            $relevantParameters = $cacheHashCalculator->getRelevantParameters(
                http_build_query($this->pageArguments->getDynamicArguments(), '', '&', PHP_QUERY_RFC3986)
            );
            $skip = empty($relevantParameters);
        }
        ...

P.S.: we detected this problem with fbclid

Related issues 3 (0 open — 3 closed)

Related to TYPO3 Core - Bug #87981: 404 Page when Google Analytics Parameters (utm_source) in URLClosed2019-03-22

Actions
Related to TYPO3 Core - Bug #88370: Extbase detail view URL call breaks by attaching params from [FE][cacheHash][excludedParameters] if page is uncachedClosed2019-05-16

Actions
Has duplicate TYPO3 Core - Bug #88070: URL with extbase action and additional query string throws error using route enhancerClosed2019-04-04

Actions
Actions
Copy link

Also available in: Atom PDF