Task #59917: User Repositories in internal persistence logic - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #59917

closed

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Epic #55656: Optimize overall Extbase performance

Story #55168: Optimize Extbase generic persistence

User Repositories in internal persistence logic

Added by Felix Oertel over 10 years ago. Updated about 8 years ago.

Status:

Rejected

Priority:

Could have

Assignee:

Felix Oertel

Category:

Extbase

Target version:

Start date:

2014-06-27

Due date:

2014-07-09

% Done:

20%

Estimated time:

24.00 h

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

Internal (e.g. when fetching child records), Extbase does not use the Repository provided by an extension but it's own methods (e.g. findByIdentifier). This leads to Extbase not using QueryCache, not respecting Orderings or other QuerySettings.

If we implement using Repositories instead, this solves all those problems at once.

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Helmut Hummel over 10 years ago

Felix Oertel wrote:

If we implement using Repositories instead, this solves all those problems at once.

What about child records that are not aggregate root, thus do not have a repository of their own?

Instead of implementing kind of a workaround, wouldn't it be more logical to implement proper ordering and caching when using the findByIdentifier() methods in the persistence manager?

Actions

Copy link

Updated by Felix Oertel over 10 years ago

Hey Helmut,

thanks for your comment.

My idea is to use a generic repository for the domain objects which are not aggregate roots.

I do not think, this solution is a workaround. Implementing a second way to retrieve objects directly (instead of through the repository) looks like a workaround to me. Why should we implement all we have in repositories (language-/-overlay-mode, ordering, enableFields, settings for storagePid, queryCache, preparedStatements, etc) a second time?

regards, foertel

Actions

Copy link

Updated by Lorenz Ulrich over 10 years ago

Is there still Work Packages budget left for this task? I completely agree with Felix.

Actions

Copy link

Updated by Felix Oertel over 10 years ago

Hey,

yep, there is some budget left and we are working on this task right now. ;-) Actually having a little two-dayed-codesprint on tue / wed ... expect to see results after that.

regards, foertel

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32286

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32286

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32286

Actions

Copy link

Updated by Mathias Schreiber about 10 years ago

Target version changed from 7.0 to 7.1 (Cleanup)

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32286

Actions

Copy link

#10