Bug #91878

Story #92091: PageTree related flaws TYPO3 v9.5.20/21-dev or v10.4.6/7-dev

Fatal error in pagetree 9.5.20

Added by Claus Harup over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Pagetree
Target version:
Start date:
2020-07-28
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.4
Tags:
pending-close
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

If you have an editor who does not have any doktypes set in 'pagetypes_select' the backend throws errors...

Nothing wrong when downgrading to 9.5.19.....

See attached images


Files

pagetree.png (9.76 KB) pagetree.png Claus Harup, 2020-07-28 13:14
console.png (56.4 KB) console.png Claus Harup, 2020-07-28 13:14

Related issues

Related to TYPO3 Core - Bug #88943: Pagetree taking extremely long to load for editorsClosed2019-08-09

Actions
Related to TYPO3 Core - Bug #91884: Page tree filter has no delete "X", needs hitting enter and has no filter info box anymore, a big backwards step regarding usabilityClosed2020-07-29

Actions
Related to TYPO3 Core - Bug #91902: Page tree not expanding deeper from initial view for editorsClosed2020-07-30

Actions
Related to TYPO3 Core - Bug #88098: Page tree XHR is fetching huge JSON dataClosed2019-04-06

Actions
Related to TYPO3 Core - Bug #88259: Filtered pagetree should display child pagesClosed2019-05-03

Actions
Related to TYPO3 Core - Bug #92045: Pagetree shows pages twiceClosed2020-08-19

Actions
Related to TYPO3 Core - Bug #92036: New behaviour of page tree filter might more easily submit "monster queries" or too many queriesAccepted2020-08-17

Actions
Has duplicate TYPO3 Core - Bug #91972: Page Tree is not loading if editor has no allowed page typesClosed2020-08-11

Actions
#1

Updated by Sybille Peters over 1 year ago

I can confirm.

Reproduced like this:

  1. Uncheck all checkboxes in user group > Access Lists > Page types [pagetypes_select]
  2. switch user to user in this group
  3. I get spinner ...
#2

Updated by Peter Wimmer over 1 year ago

i can confirm this. But resetting backend unser preferences solves the issue, so it seams something in the user preferences is causing the issue.

In maintenance the backend user settings of all users can be reset.

#3

Updated by Claus Harup over 1 year ago

Peter Wimmer wrote:

i can confirm this. But resetting backend unser preferences solves the issue, so it seams something in the user preferences is causing the issue.

In maintenance the backend user settings of all users can be reset.

Reseting the backend unser preferences does not help in my case.... :-(

#4

Updated by Oliver Hader over 1 year ago

  • Is Regression set to Yes
#5

Updated by Sebastian Lechenbauer over 1 year ago

  • Is duplicate of Bug #91407: Pagetree not shown due to error in TYPO3\CMS\Backend\Controller\Page\TreeController added
#6

Updated by Sebastian Lechenbauer over 1 year ago

  • Is duplicate of deleted (Bug #91407: Pagetree not shown due to error in TYPO3\CMS\Backend\Controller\Page\TreeController)
#7

Updated by Sebastian Lechenbauer over 1 year ago

  • Related to Bug #91407: Pagetree not shown due to error in TYPO3\CMS\Backend\Controller\Page\TreeController added
#8

Updated by Sebastian Lechenbauer over 1 year ago

I had also a missing page tree when updating to 9.5.20 - with message "Page tree error - 500 Internal Server Error". But this problem is already a little bit older, see #91407. Resetting the backend user preferences helps in this case, even better is the wizard "Update backend user configuration array" in the backend upgrade module.

#9

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65133

#10

Updated by Oliver Hader over 1 year ago

  • Related to Bug #88943: Pagetree taking extremely long to load for editors added
#11

Updated by Oliver Hader over 1 year ago

  • Related to deleted (Bug #91407: Pagetree not shown due to error in TYPO3\CMS\Backend\Controller\Page\TreeController)
#12

Updated by Oliver Hader over 1 year ago

This issue is not related to serialization, thus removing the reference to #91407.
It seems this issue has been introduced recently with #88943 in https://review.typo3.org/c/Packages/TYPO3.CMS/+/65027

#13

Updated by Patrick Broens over 1 year ago

I can confirm this as well.

We are not providing the drag and drop feature for new pages to our clients and we have the same errors in the browsers.All pages are deleted from the D&D using the TSconfig feature options.pageTree.doktypesToShowInNewPageDragArea

#14

Updated by Andreas Fernandez about 1 year ago

  • Related to Bug #91884: Page tree filter has no delete "X", needs hitting enter and has no filter info box anymore, a big backwards step regarding usability added
#15

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65133

#16

Updated by Oliver Hader about 1 year ago

  • Related to Bug #91902: Page tree not expanding deeper from initial view for editors added
#17

Updated by Oliver Hader about 1 year ago

  • Category changed from Backend JavaScript to Pagetree
#18

Updated by Sven Juergens about 1 year ago

Tested and solved the two described problems in my TYPO3 9.5.20 installations

#19

Updated by Anja Leichsenring about 1 year ago

  • Related to Bug #88098: Page tree XHR is fetching huge JSON data added
#20

Updated by Anja Leichsenring about 1 year ago

  • Related to Bug #88259: Filtered pagetree should display child pages added
#21

Updated by Richard Haeser about 1 year ago

  • Has duplicate Bug #91972: Page Tree is not loading if editor has no allowed page types added
#22

Updated by Sven Juergens about 1 year ago

ok, I just had to adapt the fourth TYPO3 installation, because this error occured in our system. A downgrade is not possible due to security reasons.
Is there currently a workaround how I can fix the bug without changing the core? Otherwise I find it a bit difficult to delay the editors until the next patch level, is there a date for that?

Best Regards
Sven

#23

Updated by Oliver Hader about 1 year ago

  • Related to Bug #92045: Pagetree shows pages twice added
#24

Updated by Oliver Hader about 1 year ago

  • Related to Bug #92036: New behaviour of page tree filter might more easily submit "monster queries" or too many queries added
#25

Updated by Oliver Hader about 1 year ago

  • Parent task set to #92091
#26

Updated by Oliver Hader about 1 year ago

Sven Juergens wrote:

ok, I just had to adapt the fourth TYPO3 installation, because this error occured in our system. A downgrade is not possible due to security reasons.
Is there currently a workaround how I can fix the bug without changing the core? Otherwise I find it a bit difficult to delay the editors until the next patch level, is there a date for that?

Best Regards
Sven

#27

Updated by Oliver Hader about 1 year ago

  • Status changed from Under Review to Needs Feedback
  • Tags set to pending-close

It seems the mentioned flaws were addressed in v9 Git branch (https://github.com/TYPO3/TYPO3.CMS/commits/9.5)

#28

Updated by Sven Juergens about 1 year ago

Hello, Oliver,
thanks for your information.
From a pure user point of view it is a bit difficult.
There was a security update for TYPO3, which included another bug. A bug which was unfortunately so big that some editors can't use TYPO3 anymore. So a published stable TYPO3 version is not usable under certain circumstances. A downgrade is not possible. As an affected user you have no other choice than to apply patches or to change to a git version of TYPO3, because you cannot use the current stable version. I am still a big fan of TYPO3 and I can understand many necessities, but especially the last updates were always a bit difficult. But then came at least a short time later RegressionUpdates, so at least a stable version was available online on get.typo3.org.

#29

Updated by Oliver Hader about 1 year ago

Sven Juergens wrote:

Hello, Oliver,
thanks for your information.
From a pure user point of view it is a bit difficult.
There was a security update for TYPO3, which included another bug. A bug which was unfortunately so big that some editors can't use TYPO3 anymore. So a published stable TYPO3 version is not usable under certain circumstances. A downgrade is not possible. As an affected user you have no other choice than to apply patches or to change to a git version of TYPO3, because you cannot use the current stable version. I am still a big fan of TYPO3 and I can understand many necessities, but especially the last updates were always a bit difficult. But then came at least a short time later RegressionUpdates, so at least a stable version was available online on get.typo3.org.

I totally understand the point and implications, but don't have any other solution for this.
For the change in the page tree that was causing these issues lots of people have been involved reviewing and testing the change. The consequences of your statements would be not to trust those reviewers and the community anymore.

Currently we only can to combined security and patch level releases - thus, there's always a risk a some bug fix introduced a new bug fix. The only alternative would be to publish standalone security versions, e.g.

  • last regular release TYPO3 v9.5.19
  • security release, only containing security fix, but no other fixes
    • create new branch 9.5.19.x based on tag v9.5.19
    • apply security changes to 9.5.19.x branch and to regular 9.5 branch
    • create v9.5.19.1 security only release from 9.5.19.x branch
    • create v9.5.20 security and bug fix release from 9.5 branch
  • regressions then again would have to be fixed in both 9.5.19.x and 9.5 branches
    • leads to v9.5.19.2 regression fixes for 9.5.19.1
    • leads to v9.5.21 regression fixes for 9.5.20

Thus, instead of currently releasing two versions (for 9.5 and 10.4) we would then have to release four versions (9.5.19.1, 9.5.20, 10.4.a.1, 10.4.a+1). Basically all processed would have to be adjusted - Git, review.typo3.org, get.typo3.org, maintenance pages & content, bamboo.typo3.com, Travis CI, ... any other tools being involved here.

In general it currently would help if people were using the existing 9.5 and 10.4 dev-branches(!) in their sites under development.

#30

Updated by Oliver Hader about 1 year ago

  • Status changed from Needs Feedback to Closed

Closing this actual issue seems to be solved, other comments were off-topic related to release process.

#31

Updated by Sybille Peters about 1 year ago

In general it currently would help if people were using the existing 9.5 and 10.4 dev-branches(!) in their sites under development.

I think that is a very good suggestion. I had not thought of that. I will change some of my dev + test sites to use latest versions of the core from git.

Incidentally, I was one of the reviewers of the patch that initially caused the problem. I did feel bad about the mess, but the patch did not cause any problems on my site and I have been happily using it since. Actually it fixed a big and annoying problem of page tree performance which made the page tree almost unusable for admins. So, you see it is not always easy to detect all possible error cases in advance. The core contributors are already doing a lot, e.g. by adding tests etc.

I think it would help a lot if more people reviewed and tested the patches on Gerrit and did use latest versions of core from git on test and dev servers.

Also available in: Atom PDF