Project

General

Profile

Actions

Bug #100348

closed

Epic #99669: CKEditor5 Collection

ckeditor 5 does not allow styling of UL/OL elements

Added by Sven Carstens about 1 year ago. Updated 9 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
Start date:
2023-03-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

ckeditor 4 did allow for the styling of UL/OL via css classes.
Applying the following configuration in ckeditor 5 will only allow to style the individial LI elements or a complete P element.

editor:
    config:
        style:
            definitions:
                - { name: " Checkmarks UL", element: "ul", classes: ['list-unordered-checkmarks'] }
                - { name: " Checkmarks P", element: "p", classes: ['list-unordered-checkmarks'] }
                - { name: " Checkmarks LI", element: "li", classes: ['list-unordered-checkmarks'] }

Seems to be a general problem with ckeditor 5 not yet supporting this (and other) use-cases.

Related drupal issue https://www.drupal.org/project/drupal/issues/3326261


Files

ckeditor5-bundle.js.patch (1.13 KB) ckeditor5-bundle.js.patch Hendrik N, 2023-06-14 10:33

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #100908: Update ckeditor5 to 38.0Closed2023-05-23

Actions
Actions #2

Updated by Tymoteusz Motylewski about 1 year ago

Actions #3

Updated by Tymoteusz Motylewski about 1 year ago

here is a patch which upgrades ckeditor to v38
https://review.typo3.org/c/Packages/TYPO3.CMS/+/79133
please confirm whether it solves the issue for you

Actions #4

Updated by Marc Hirdes about 1 year ago

Thanks for the fast patch. But I still can not select the style. I also get a JS error:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'attach') at VM493 ckeditor5.js:21:1151
Actions #5

Updated by Benni Mack about 1 year ago

  • Target version changed from 12 LTS to Candidate for patchlevel
Actions #6

Updated by Hendrik N about 1 year ago

As mentioned here https://github.com/ckeditor/ckeditor5/issues/14200#issuecomment-1589006697 the fix is only for "DocumentList", not for "List" (which is imported in Build/Sources/JavaScript/rte_ckeditor/contrib/ckeditor5-bundle.js)

The attached patch fixes the issse.

Actions #7

Updated by Gerrit Code Review 12 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79701

Actions #8

Updated by Gerrit Code Review 12 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79701

Actions #9

Updated by Gerrit Code Review 12 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79701

Actions #10

Updated by Andreas Steiner 12 months ago

  • Target version changed from Candidate for patchlevel to next-patchlevel
Actions #11

Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80689

Actions #12

Updated by Benjamin Serfhos 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Benjamin Franzke 9 months ago

  • Parent task set to #99669
Actions

Also available in: Atom PDF