Project

General

Profile

Actions

Bug #20335

closed

Hidden Content Elements are displayed in the Module "View Page"

Added by erik dahlin about 14 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2009-04-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Content elements with property "hidden" shows up while using the View module on a non-admin user and adminpanel disabled.

They do not show up on the website, only in the backend while previewing the webpage using the "View" module.

Some test I've done:

using the following TS config
admPanel.override.preview.showHiddenPages=0
admPanel.override.preview.showHiddenRecords=0

version 4.2.2 - hidden elements doesnt show.
version 4.2.5 - hidden elements shows up.
version 4.2.6 - hidden elements shows up.
(issue imported from #M10951)


Files

patch_9843_carefull.diff (868 Bytes) patch_9843_carefull.diff Administrator Admin, 2009-05-29 20:52
patch_9843_mabycleaner.diff (806 Bytes) patch_9843_mabycleaner.diff Administrator Admin, 2009-05-29 20:53
10951.diff (1.22 KB) 10951.diff Administrator Admin, 2009-06-10 03:25
10951_r7462.diff (1.25 KB) 10951_r7462.diff Administrator Admin, 2010-05-17 21:57
patch_20335.diff (1.55 KB) patch_20335.diff Tobias Wollender, 2014-02-10 19:10

Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Bug #20524: Hide on FE-login still shows elemens in simulation modeClosed2009-05-29

Actions
Has duplicate TYPO3 Core - Bug #19644: Hidden pages become visible ifClosedChristian Kuhn2008-11-25

Actions
Has duplicate TYPO3 Core - Bug #22316: "View" Function ignores "Show Hidden Pages" option, shows all hidden pagesClosedChris topher2010-03-23

Actions
Actions #1

Updated by Chris topher about 14 years ago

I have the same problem.
This problem is also discussed in this thread:
http://lists.typo3.org/pipermail/typo3-english/2009-May/061076.html

Summary of the thread:
The problem is only in the module web>view.

Viewing a page in the FE works correctly.
Hiding/showing there works correctly for pages and content-elements (after you pressed it twice(!); another bug, not to be solved here).

In the BE-module there are two cases:
- If I choose a page in the tree (e.g. the start-page), the refresh-button
does not have any effect (also if I press it twice).
It works neither for pages nor for content-elements.
- If I choose the globe (which then shows me the start-page), the
refresh-button works as in the frontend: I have to click it twice, but then
hiding/showing pages and content-elements works.
(If I then click on the page/another page in the tree, I again see everything.)

The problem exists for admin- and non-admin-users.

It does not matter, if the admin-panel is visible or hidden.

Actions #2

Updated by Nabil Saleh about 14 years ago

please test the patches as i'm not shure about possible sideeffects

Actions #3

Updated by Niels Fröhling almost 14 years ago

The final patch removes "ADMCMD_view" from tslib_fe entirely.

"ADMCMD_view" means that the page is view from out of the Web->View (the View-Module does make an explicit redirect adding that parameter).
It is an indicator from where we are seeing a page and can't be used to determine what we are seeing.

Subsequently the variable "fePreview = 2" also indicates to display some workspace information at the top, and can't be used to switch a preview-mode, and has been removed from the check.

Actions #4

Updated by Tobias Lohmann about 13 years ago

Final patch works for me regarding the differences in Web-Module "View" and page-tree "View" (PHP 5.2, T3 4.3.2, see http://bugs.typo3.org/view.php?id=13894).

But: is it a correct behaviour when previewing a hidden page, that all other hidden pages on the same level are shown in the menu too? When previewing a non-hidden page the hidden pages do not show up in menus (which is what I would expect for previewing in general).

Actions #5

Updated by Chris topher about 13 years ago

Attached an updated patch by Steffen Ritter.

Actions #6

Updated by Felix Nagel about 12 years ago

  • Target version deleted (0)

This problem persists even in TYPO3 4.5.2

When using a TS config like

# both parts needed for access restricted pages
# for non admin and admin BE user 
admPanel.override {
          preview = 1
      preview.simulateUserGroup = 8  
      preview.showHiddenPages = 1
      preview.showHiddenRecords = 0
}

admPanel {
       enable {
          preview = 1
          preview.simulateUserGroup = 8
          preview.showHiddenPages = 1
          preview.showHiddenRecords = 0
      }
      hide = 1
}

to enable preview of restricted pages for BE users, but all hidden records are shown when using context menu "Show".

Actions #7

Updated by Sara no-lastname-given over 11 years ago

Typo3 4.6.0 also still shows all elements (hidden/timed/unused etc) in the View module, both in the live and custom workspaces.

Actions #8

Updated by Florian Seirer almost 11 years ago

Still happening on 4.7.2.
At least the patch still works.

It has been three years (!) and only a handful of people are bothered by this?

Actions #9

Updated by Alexander Opitz almost 10 years ago

As TYPO3 CMS 4.7 gets only security fixes, does this issue exists with TYPO3 CMS 6.1?

Actions #10

Updated by Alexander Opitz almost 10 years ago

  • Status changed from New to Needs Feedback
Actions #11

Updated by Jochen Wirth over 9 years ago

Problem still exists on TYPO3 6.1.5

My Configuration for the Backenduser:

admPanel.override {
preview = 1
preview.simulateUserGroup = 11
preview.showHiddenPages = 0
preview.showHiddenRecords = 0
}

admPanel {
enable {
preview = 1
preview.simulateUserGroup = 11
preview.showHiddenPages = 0
preview.showHiddenRecords = 0
}
hide = 1
}

=> no effect; hidden Content is still visible

Greetz

Joe

Actions #12

Updated by Alexander Opitz over 9 years ago

  • Status changed from Needs Feedback to New
  • Is Regression set to No
Actions #13

Updated by Alexander Opitz over 9 years ago

  • Category set to Backend User Interface
Actions #14

Updated by Tobias Wollender over 9 years ago

I'm having this problem in 6.2 too. The proposed patch in this ticket works in my case (although the file to path has changed). I attach the patch I used.

Actions #15

Updated by Stefan Froemken over 8 years ago

This problem comes with TYPO3 4.2.3. Following line:

$this->sys_page->versioningPreview = $this->fePreview ? TRUE : FALSE;

was changed to:

$this->sys_page->versioningPreview = ($this->fePreview===2 || intval($this->workspacePreview) || t3lib_div::_GP('ADMCMD_view')) ? TRUE : FALSE;

Since years and today some GET-Parameters will be added to the URL of the iFrame in view-module. One of them is: &ADMCMD_view=1

With the change in TYPO3 4.2.3 $this->sys_page->versioningPreview is TRUE now.

In enableFields we have these lines:

if (!$this->versioningPreview || !$ctrl['versioningWS'] || $noVersionPreview) {
    if ($ctrl['enablecolumns']['disabled'] && !$show_hidden && !$ignore_array['disabled']) {

As versioningPreview is TRUE now the variable $show_hidden was not processed anymore and that's why hidden records are shown in view module.

Actions #16

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35817

Actions #17

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35817

Actions #18

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35817

Actions #19

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36017

Actions #20

Updated by Stefan Froemken over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #21

Updated by Marcus Schwemer about 8 years ago

Hi,

is it a bug or a feature?

This changed behaviour leads back until 4.2 and was then considered as a bug (6 years ago). In these 6 years many TYPO3 users, as some customers and myself, considered it as a feature ... to be able to preview hidden records, that a currently edited, but not published yet.

To be honest ... I am in favor of reverting the patch an reactivating the feature.

Best regards,
Marcus

Actions #22

Updated by Christian Buelter about 8 years ago

Hi Marcus,

if I understand it right you are still able to preview hidden records by activating that feature in the AdminPanel.

Actions #23

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF